New issue
Advanced search Search tips

Issue 762889 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests]: Code clean up : check null for preventing crash in core/layout

Project Member Reported by hdodda@chromium.org, Sep 7 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
===
https://chromium.googlesource.com/chromium/src.git/+/bf20977ca2b1af2eff9769679dc45015711c0b57

Ref Bug: 
========
https://bugs.chromium.org/p/chromium/issues/detail?id=71041

Note : As the owner doesn't seem to have chromium id , assigning it to the reviewer.

Thank you!
 


 
Status: WontFix (was: Assigned)
The patch was code cleanup, with no functional change. The change title is a little misleading, in that it removed an unnecessary null check, not added. The wide range of existing tests for positioned objects would have discovered a problem if there was one.

Sign in to add a comment