New issue
Advanced search Search tips

Issue 762876 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Merge to M62: Add new metric reported by WebRTC via GetStats.

Project Member Reported by ilnik@chromium.org, Sep 7 2017

Issue description

One new metric is requested by HotLane team. 

Original webrtc bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=8174

Landed in webrtc here:
https://chromium.googlesource.com/external/webrtc/+/2e1b40bdf63743b07388628707c4b8e349495807

Landed in chrome here:
https://chromium.googlesource.com/chromium/src/+/04935f101e6b5cf9d594447e48cbd5f26b9785f3
which was included in 63.0.3207.0

This change doesn't affect user experience at all
 

Comment 1 by ilnik@chromium.org, Sep 7 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 8 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2017

Labels: merge-merged-62
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/344afb52615f11c1007781d545d36efb20271c04

commit 344afb52615f11c1007781d545d36efb20271c04
Author: ilnik <ilnik@webrtc.org>
Date: Fri Sep 08 12:34:55 2017

Implement googContentType GetStats metric reported on receive side.

Reported per video stream as a string.

Merge into M62. Original was reviewed here: https://codereview.webrtc.org/3009793002

BUG= webrtc:8174 , chromium:762876 

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.webrtc.org/3005263002
Cr-Commit-Position: refs/branch-heads/62@{#7}
Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592}

[modify] https://crrev.com/344afb52615f11c1007781d545d36efb20271c04/webrtc/api/statstypes.cc
[modify] https://crrev.com/344afb52615f11c1007781d545d36efb20271c04/webrtc/api/statstypes.h
[modify] https://crrev.com/344afb52615f11c1007781d545d36efb20271c04/webrtc/api/video/video_content_type.cc
[modify] https://crrev.com/344afb52615f11c1007781d545d36efb20271c04/webrtc/api/video/video_content_type.h
[modify] https://crrev.com/344afb52615f11c1007781d545d36efb20271c04/webrtc/call/video_receive_stream.h
[modify] https://crrev.com/344afb52615f11c1007781d545d36efb20271c04/webrtc/media/base/mediachannel.h
[modify] https://crrev.com/344afb52615f11c1007781d545d36efb20271c04/webrtc/media/engine/webrtcvideoengine.cc
[modify] https://crrev.com/344afb52615f11c1007781d545d36efb20271c04/webrtc/pc/statscollector.cc
[modify] https://crrev.com/344afb52615f11c1007781d545d36efb20271c04/webrtc/video/receive_statistics_proxy.cc
[modify] https://crrev.com/344afb52615f11c1007781d545d36efb20271c04/webrtc/video/receive_statistics_proxy_unittest.cc

Comment 4 by ilnik@chromium.org, Sep 8 2017

Labels: merge-merged-3202
Status: Fixed (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 11 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by ilnik@chromium.org, Sep 11 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-62

Sign in to add a comment