TranslateLanguageBrowserTest.LanguageModelLogSucceed flaky on Linux Tests |
|||
Issue descriptionTranslateLanguageBrowserTest.LanguageModelLogSucceed flaky Builders failed on: - Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests Test output [ RUN ] TranslateLanguageBrowserTest.LanguageModelLogSucceed Xlib: extension "RANDR" missing on display ":99". [24530:24530:0906/202859.036291:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. ../../chrome/browser/ui/views/translate/translate_language_browsertest.cc:79: Failure Expected: (expect_translate) != (bubble == nullptr), actual: true vs true [24530:24530:0906/202859.919283:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers. [ FAILED ] TranslateLanguageBrowserTest.LanguageModelLogSucceed, where TypeParam = and GetParam() = (1479 ms)
,
Sep 7 2017
,
Sep 7 2017
Culprit: https://chromium.googlesource.com/chromium/src/+/270e75744242cd7d88d6a52e15a1749e0b2803d0 I'm gonna go ahead and revert that CL, and then hand this over to renjieliu@
,
Sep 7 2017
Landed revert here: https://chromium-review.googlesource.com/c/chromium/src/+/654258
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/697e08e20f6894a11dfc13a1d3ef68e69168fffc commit 697e08e20f6894a11dfc13a1d3ef68e69168fffc Author: Renjie Liu <renjieliu@chromium.org> Date: Fri Sep 08 07:52:23 2017 Fix flaky test. The reason is chrome by default opens blank/about page which cause the cld to detect as und, and when we wait for french to be detected, it's actually und got passed in. By fixing this bug, we can fix crbug.com/394066 and http://crbug.com/378061 as well. Bug: 762875 Change-Id: Ib2cb9e493e9d9f2a03e5594e37a048136798a313 Reviewed-on: https://chromium-review.googlesource.com/656871 Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Renjie Liu <renjieliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#500534} [add] https://crrev.com/697e08e20f6894a11dfc13a1d3ef68e69168fffc/chrome/browser/ui/views/translate/translate_language_browsertest.cc [modify] https://crrev.com/697e08e20f6894a11dfc13a1d3ef68e69168fffc/chrome/test/BUILD.gn |
|||
►
Sign in to add a comment |
|||
Comment 1 by gsennton@chromium.org
, Sep 7 2017