New issue
Advanced search Search tips

Issue 762872 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Merge to M62: Change how WebRTC reports a metric via GetStats

Project Member Reported by ilnik@chromium.org, Sep 7 2017

Issue description

Change in how one metric is reported is requested by HotLane team. 

Original webrtc bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=7594

Landed in webrtc here:
https://chromium.googlesource.com/external/webrtc/+/75204c5ccdda561ccffbfa3a8fa94feac8e19e30

Landed in chrome here:
https://chromium.googlesource.com/chromium/src/+/04935f101e6b5cf9d594447e48cbd5f26b9785f3
which was included in 63.0.3207.0

This change doesn't affect user experience at all

 

Comment 1 by ilnik@chromium.org, Sep 7 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 8 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2017

Labels: merge-merged-62
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/625b4cccdb02c07405106ed7b312956dae9d003e

commit 625b4cccdb02c07405106ed7b312956dae9d003e
Author: ilnik <ilnik@webrtc.org>
Date: Fri Sep 08 12:27:43 2017

Change reporting of timing frames conditions in GetStats on receive side

Instead of the longest frame since the last GetStats call, the longest
frame received during last 10 seconds should be returned in GetStats().

Previous way is not a good idea because there are maybe several
consumers of GetStats calls. If not all of them parse timing frame
reports, some of them may be lost.

Also, streamline reporting of TimingFrames via GetStats (remove separate
methods and use VideoReceiveStream::Stats struct instead).

Merge into M62. Original reviewed here: https://codereview.webrtc.org/3008983002

BUG=webrtc:7594, chromium:762872 
NOTRY=true
NOPRESUBMIT=true
TBR=sprang@webrtc.org

Review-Url: https://codereview.webrtc.org/3012073002
Cr-Commit-Position: refs/branch-heads/62@{#6}
Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592}

[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/api/video/video_timing.cc
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/api/video/video_timing.h
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/call/video_receive_stream.h
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/media/engine/fakewebrtccall.cc
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/media/engine/fakewebrtccall.h
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/media/engine/webrtcvideoengine.cc
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/video/end_to_end_tests.cc
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/video/receive_statistics_proxy.cc
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/video/receive_statistics_proxy.h
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/video/receive_statistics_proxy_unittest.cc
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/video/video_receive_stream.cc
[modify] https://crrev.com/625b4cccdb02c07405106ed7b312956dae9d003e/webrtc/video/video_receive_stream.h

Comment 4 by ilnik@chromium.org, Sep 8 2017

Labels: merge-merged-3202
Status: Fixed (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 11 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by ilnik@chromium.org, Sep 11 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-62

Sign in to add a comment