+ Lindsay

As discussed in person, we should revert the workaround since it is fixed by the OS and make sure this is covered by our testing team.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb15ca69a28f1cc2c363fea4d02acd3d5c30ad43

commit fb15ca69a28f1cc2c363fea4d02acd3d5c30ad43
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Fri Sep 08 14:17:21 2017

Revert index spotlight xcallbacks in Chrome

The bug was fixed in iOS 11.
This reverts most part of
https://chromium-review.googlesource.com/c/chromium/src/+/608227

Bug:  762869 
Change-Id: I364b03deda2c8e56023bbd25a128d3bcb5ca7903
Reviewed-on: https://chromium-review.googlesource.com/655237
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500585}
[modify] https://crrev.com/fb15ca69a28f1cc2c363fea4d02acd3d5c30ad43/ios/chrome/app/spotlight/BUILD.gn
[modify] https://crrev.com/fb15ca69a28f1cc2c363fea4d02acd3d5c30ad43/ios/chrome/app/spotlight/base_spotlight_manager.mm

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Just to be clear, this is reverting the fix as landed for issue 750115 ?

olivierrobin@ how risky can reverting this change be? 

#5: Yes, the bug has been fixed by Apple. So we want to revert the workaround.

The code part is not risky at all for stable users, as it revert to previous code.
For canary users, and for testflight users if we release one testflight before cherry-pick, there may be a small risk that they see twice the same URL if they have both a bookmark and a most visited pointing to the same URL. This will resolve itself in at most one week.

The only real risk is a regression in Apple iOS11 final version that reintroduce the bug.  (or users really wanting to keep iOS11beta5). But 
1. this is really unlikely, and better than having the popup for users using spotlight.
2. this revert will happen anyway in the transition 62-63

Verified as per the steps in 750115. Tapping on results from spotlight search opens the link in chrome app.
verified on 63.0.3213.0 Canary iPad iOS 11.0 Beta 9, iPhone 6+ OS 11.0 Beta 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65e81082db80020ba28198f68c4152398101313c

commit 65e81082db80020ba28198f68c4152398101313c
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Fri Sep 15 15:33:51 2017

Revert index spotlight xcallbacks in Chrome

The bug was fixed in iOS 11.
This reverts most part of
https://chromium-review.googlesource.com/c/chromium/src/+/608227

TBR=olivierrobin@chromium.org

(cherry picked from commit fb15ca69a28f1cc2c363fea4d02acd3d5c30ad43)

Bug:  762869 
Change-Id: I364b03deda2c8e56023bbd25a128d3bcb5ca7903
Reviewed-on: https://chromium-review.googlesource.com/655237
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500585}
Reviewed-on: https://chromium-review.googlesource.com/668537
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#248}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/65e81082db80020ba28198f68c4152398101313c/ios/chrome/app/spotlight/BUILD.gn
[modify] https://crrev.com/65e81082db80020ba28198f68c4152398101313c/ios/chrome/app/spotlight/base_spotlight_manager.mm

Verified in:

App version: 62.0.3202.29 beta
Devices: iPhone 5S, iPad Air
iOS Version: 11.0

Tapping on spotlight search results opens up the link in Chrome app.