New issue
Advanced search Search tips

Issue 762867 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature



Sign in to add a comment

Merge to M62: Additional metrics reporting for WebRTC experiments.

Project Member Reported by ilnik@chromium.org, Sep 7 2017

Issue description

This change adds new and and more finely sliced metrics for video streams reported to UMA. Original webrtc bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=8032

Landed in webrtc here:
https://chromium.googlesource.com/external/webrtc.git/+/6d5b4d6fe13951a7f3f6ed3d3b29bc601920e381

Landed in chrome here:
https://chromium.googlesource.com/chromium/src/+/04935f101e6b5cf9d594447e48cbd5f26b9785f3
which was included in 63.0.3207.0

This change doesn't affect user experience at all.
 

Comment 1 by ilnik@chromium.org, Sep 7 2017

Owner: ilnik@chromium.org

Comment 2 by ilnik@chromium.org, Sep 7 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 8 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2017

Labels: merge-merged-62
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/7f333377b8d7bda58cd262cd8d698d60347d7a3c

commit 7f333377b8d7bda58cd262cd8d698d60347d7a3c
Author: ilnik <ilnik@webrtc.org>
Date: Fri Sep 08 10:12:18 2017

Piggybacking simulcast id and ALR experiment id into video content type extension. Use it to slice UMA video receive statis.
Merge into M62. Original was reviewed here: https://codereview.webrtc.org/2986893002

BUG= webrtc:8032 , chromium:762867 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.webrtc.org/2986893002
Cr-Original-Commit-Position: refs/heads/master@{#19598}
(cherry picked from commit 6d5b4d6fe13951a7f3f6ed3d3b29bc601920e381)
Review-Url: https://codereview.webrtc.org/3013503002
Cr-Commit-Position: refs/branch-heads/62@{#4}
Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592}

[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/api/BUILD.gn
[add] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/api/video/video_content_type.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/api/video/video_content_type.h
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/common_video/include/video_frame.h
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/modules/pacing/alr_detector.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/modules/pacing/alr_detector.h
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/modules/video_coding/BUILD.gn
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/modules/video_coding/frame_buffer2.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/modules/video_coding/frame_buffer2_unittest.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/modules/video_coding/generic_encoder.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/modules/video_coding/generic_encoder.h
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/modules/video_coding/include/video_coding_defines.h
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/system_wrappers/include/metrics.h
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/video/end_to_end_tests.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/video/receive_statistics_proxy.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/video/receive_statistics_proxy.h
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/video/receive_statistics_proxy_unittest.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/video/video_send_stream_tests.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/video/video_stream_decoder.cc
[modify] https://crrev.com/7f333377b8d7bda58cd262cd8d698d60347d7a3c/webrtc/video/video_stream_decoder.h

Comment 5 by ilnik@chromium.org, Sep 8 2017

Labels: M-62 merge-merged-3202

Comment 6 by ilnik@chromium.org, Sep 8 2017

Status: Fixed (was: Assigned)
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 11 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by ilnik@chromium.org, Sep 11 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-62

Sign in to add a comment