In content settings UI code, onChangePermissionControl_() should observe controlParams_.enforcement |
|||
Issue descriptionPatch crrev.com/c/602840 added a dependency of controlParams_.enforcement to onChangePermissionControl(), without adding it as an observer argument. This seems to work for now but we should make make it an observer argument. https://www.polymer-project.org/1.0/docs/devguide/observers#dependencies
,
Nov 10 2017
,
Dec 22 2017
WontFix. After some investigation this looks correct as-is. The |enforcement| member is optional*. The current observer is waiting for |controlParams_.value| to be set. The |value| member is not optional, so that's a good indication that the record is ready. * https://cs.chromium.org/chromium/src/chrome/common/extensions/api/settings_private.idl?type=cs&sq=package:chromium&l=42 |
|||
►
Sign in to add a comment |
|||
Comment 1 by timloh@chromium.org
, Sep 7 2017