Issue metadata
Sign in to add a comment
|
browser_tests failing: GalleryJsTest.ExifEncoderTest |
||||||||||||||||||||
Issue descriptionbrowser_tests failing on: - Linux Chromium OS ASan LSan Tests (1): https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 [ RUN ] GalleryJsTest.ExifEncoderTest [5584:5584:0906/165107.256062:WARNING:chrome_browser_main_chromeos.cc(546)] Running as stub user with profile dir: test-user [5584:5598:0906/165107.683939:ERROR:logging_chrome.cc(210)] Unable to create symlink /b/s/w/itu6mmv7/.org.chromium.Chromium.5MFaMJ/d5C899n/test-user/chrome_debug.log pointing at /b/s/w/itu6mmv7/.org.chromium.Chromium.5MFaMJ/d5C899n/test-user/chrome_debug_20170906-165107: No such file or directory (2) [5584:5596:0906/165108.141134:WARNING:freezer_cgroup_process_manager.cc(62)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [5584:5603:0906/165108.221974:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin [5584:5584:0906/165110.351408:INFO:CONSOLE(186)] "Failure in test testLargeExifDataBoundaryCase Error: Assertion Failed Observed: false Expected: true", source: (186) [5584:5584:0906/165110.352408:INFO:CONSOLE(187)] "Error: Assertion Failed Observed: false Expected: true at assertEquals (<anonymous>:18:11) at largeExifDataTestHelper_ (file:///b/s/w/ir/ui/file_manager/gallery/js/image_editor/exif_encoder_unittest.js:170:3) at testLargeExifDataBoundaryCase (file:///b/s/w/ir/ui/file_manager/gallery/js/image_editor/exif_encoder_unittest.js:188:3) at continueTesting (<anonymous>:184:17) at continueTesting (<anonymous>:192:7) at runTests (<anonymous>:160:3) at <anonymous>:1:1", source: (187) Reliable failure (happened on the last 6 runs). Last known good: r500057 First known bad: r500093
,
Sep 7 2017
There are three test cases here: testLargeExifDataSmallCase -- leaves 159 bytes for thumbnail, expect true testLargeExifDataBoundaryCase -- leaves 158 bytes for thumbnail, expect true testLargeExifDataExceedsCase -- leaves 157 bytes for thumbnail, expect false The Boundary case (158 bytes) is apparently exactly enough for the thumbnail to fit, so expect it to fit. The Exceeds case it should not fit. What we are seeing here is the Boundary case failing; it returns false when it's expected to be true. The other two cases pass. That means there is some kind of off-by-one error. I don't know why it's only failing on ASan (perhaps it isn't). I can't find any relevant looking changes.
,
Sep 7 2017
I can't figure out what could've changed (after staring at this code for a long time). ASan only failure (flakiness dashboard shows green on regular builds), and I can't explain that either since it looks like a simple off-by-one error. yawano@ wrote these tests in 2015. Disabling the test on ASan and assigning to you.
,
Sep 7 2017
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e4777f9ee04aae9e0879c476c860b5b84776ea4 commit 7e4777f9ee04aae9e0879c476c860b5b84776ea4 Author: Matt Giuca <mgiuca@chromium.org> Date: Thu Sep 07 08:39:29 2017 Disabled GalleryJsTest.ExifEncoderTest on ASan. Consistent failure, but only on ASan builds. Bug: 762831 Tbr: hirono@chromium.org Change-Id: I16705517d75b711fa92bc980f242cf7d3e62c0c8 Reviewed-on: https://chromium-review.googlesource.com/654471 Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#500246} [modify] https://crrev.com/7e4777f9ee04aae9e0879c476c860b5b84776ea4/chrome/browser/chromeos/file_manager/gallery_jstest.cc
,
Sep 7 2017
,
Feb 6 2018
,
Feb 23 2018
,
Feb 28 2018
,
Feb 28 2018
,
Feb 28 2018
,
Jun 8 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by mgiuca@chromium.org
, Sep 7 2017