New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762808 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Missing Test] : setting HTTP proxy for headless mode is not working in Selenium

Project Member Reported by brajkumar@chromium.org, Sep 7 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
----
https://chromium.googlesource.com/chromium/src/+/1bf0e95c7566a1064a89d9c4874a1659060b0a8f

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=750556

Thank you!
 

Comment 1 by rvera@google.com, Sep 18 2017

Status: WontFix (was: Assigned)
I did think about tests and decided not to write them. The underlying proxy code has unit tests. This very small change merely plumbs a bit more of the existing chromium proxy code into headless, which uses only a subset of chromium. I'm not sure how to test just this change in a meaningful way without a disproportionate amount of work for very little gain. Hence marking as Won't Fix.

Sign in to add a comment