New issue
Advanced search Search tips

Issue 762764 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 671916



Sign in to add a comment

[MacViewsBrowser] bookmark folder does not open on mouse over

Reported by jongkwon...@navercorp.com, Sep 7 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.0 Safari/537.36

Steps to reproduce the problem:
1. build chrome with mac_views_browser=1 and run
2. open a bookmark folder on bookmark bar
3. move mouse pointer to another bookmark folder on bookmark bar

What is the expected behavior?
New bookmark folder should open automatically and old one should close.

What went wrong?
Old bookmark folder remain open and new bookmark folder does not open.

Did this work before? No 

Chrome version: 62.0.3202.0  Channel: n/a
OS Version: OS X 10.12.6
Flash Version:
 

Comment 1 by ajha@chromium.org, Sep 7 2017

Components: -UI UI>Browser>Bookmarks Internals>Views
Labels: Needs-Triage-M62 TE-NeedsTriageHelp
Looks to be debug build related, hence adding proper component for someone from the respective team to take a look at this.
Cc: tapted@chromium.org
Labels: Proj-MacViews

Comment 3 by shrike@chromium.org, Sep 16 2017

Labels: MacViews-Browser
Status: Available (was: Unconfirmed)
Lots of these error messages in the console:

[31757:775:0915/171529.541005:ERROR:screen_mac.mm(164)] Not implemented reached in virtual bool display::(anonymous namespace)::ScreenMac::IsWindowUnderCursor(gfx::NativeWindow)

Blocking: 671916
Thanks for all of these! I'll do a big triage of  Issue 671916  blockers when the current phase is complete. See go/macviewstracking
Labels: M-68
[Bulk Edit]
Applying M-68 milestone per email discussion with ellyjones@. Pls change it if milestone is incorrectly applied. 
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b893f3bd4fa2dfe56d207066b644f4c63433794e

commit b893f3bd4fa2dfe56d207066b644f4c63433794e
Author: jongkwon.lee <jongkwon.lee@navercorp.com>
Date: Mon Feb 26 16:51:32 2018

Implement IsWindowUnderCursor()

MacViewsBrowser, it is necessary to open bookmark menus on mouse
over. So, implement the unimplemented function IsWindowUnderCursor().

MenuController: :ShowSiblingMenu() use IsWindowUnderCursor(). On
Bug:  762764 
Change-Id: Ifbf93085a0546f7e3c2b6070267e62212b84bddd
Reviewed-on: https://chromium-review.googlesource.com/654400
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539165}
[modify] https://crrev.com/b893f3bd4fa2dfe56d207066b644f4c63433794e/ui/display/mac/screen_mac.mm

Status: Fixed (was: Available)
This looks Fixed. Thanks #7 :)

Sign in to add a comment