New issue
Advanced search Search tips

Issue 762763 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Fix flaky browser test for parallel download

Project Member Reported by xingliu@chromium.org, Sep 7 2017

Issue description

ParallelDownloadResumption is currently flaky, it is caused by bug in an edge case in download resumption.

Root cause: the first hole in file in resumption can be filled before we send parallel requests, it will fail to send a request to fill the second hole. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3fcf2065c6e6e7617462a050e6503a844caaa9b

commit b3fcf2065c6e6e7617462a050e6503a844caaa9b
Author: Xing Liu <xingliu@chromium.org>
Date: Tue Sep 12 00:52:08 2017

Fix a flaky browser test for parallel download.

ParallelDownloadResumption is flaky previously, the cause is an edge
case bug in download resumption with a prallel download, that first
hole can be filled before creating parallel requests.

The impact of this bug is very small. Repro rate in browser test is
only 1-2%, and resumption only happens for 4.9% for all downloads.

Bug:  762763 
Change-Id: I00efbc14ec40f484f3ef111f8237894c4009ba6d
Reviewed-on: https://chromium-review.googlesource.com/653314
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501127}
[modify] https://crrev.com/b3fcf2065c6e6e7617462a050e6503a844caaa9b/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/b3fcf2065c6e6e7617462a050e6503a844caaa9b/content/browser/download/mock_download_item_impl.cc
[modify] https://crrev.com/b3fcf2065c6e6e7617462a050e6503a844caaa9b/content/browser/download/mock_download_item_impl.h
[modify] https://crrev.com/b3fcf2065c6e6e7617462a050e6503a844caaa9b/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/b3fcf2065c6e6e7617462a050e6503a844caaa9b/content/browser/download/parallel_download_job.h
[modify] https://crrev.com/b3fcf2065c6e6e7617462a050e6503a844caaa9b/content/browser/download/parallel_download_job_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment