New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762761 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Do runtime title set for paste as plain text.

Project Member Reported by ctzsm@chromium.org, Sep 7 2017

Issue description

As discussed in https://chromium-review.googlesource.com/c/chromium/src/+/652964, when running on below-O devices, the resource id is pointing to a wrong resource. Since we removed the corresponding menu item on below-O, so we won't see it. However, it is still fundamentally wrong because on below-O devices it depends on if we had enough resources as padding. We should remove this kind of dependency.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/585b72e06ab6dd043aeefb44951e347337593303

commit 585b72e06ab6dd043aeefb44951e347337593303
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Thu Sep 07 22:50:55 2017

[Android] Set "paste as plain text" title after inflation 

As discussed in
https://chromium-review.googlesource.com/c/chromium/src/+/652964,
when running on below-O devices, the resource id is pointing to a wrong
resource. Since we removed the corresponding menu item on below-O, so we
won't see it. However, it is still fundamentally wrong because on
below-O devices it depends on if we had enough resources as padding. We
should remove this kind of dependency.

Bug:  762761 
Change-Id: I39fec854341300d355d4a5203e4a446ff5e16e51
Reviewed-on: https://chromium-review.googlesource.com/654441
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500421}
[modify] https://crrev.com/585b72e06ab6dd043aeefb44951e347337593303/content/public/android/java/res/menu/select_action_menu.xml
[modify] https://crrev.com/585b72e06ab6dd043aeefb44951e347337593303/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
[modify] https://crrev.com/585b72e06ab6dd043aeefb44951e347337593303/content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java

Comment 2 by ctzsm@chromium.org, Sep 7 2017

Status: Fixed (was: Assigned)
wnwen@, change in https://chromium-review.googlesource.com/c/chromium/src/+/652964 for select_action_menu.xml is not needed, could you update it correspondingly, thanks!

Comment 3 by wnwen@chromium.org, Sep 11 2017

Done. Thank you!

Sign in to add a comment