Site Details doesn't work with file:// scheme URLs. |
||||||
Issue descriptionChrome Version : 63.0.3207.0 OS Version: Chrome Desktop What steps will reproduce the problem? 1. Open a file in a new Chrome tab. It should show "file://..." in the omnibox. 2. Click the info icon next to the URL to open Page Info and click "Site settings". What is the expected result? When Site Details opens, it should show the full file:// url/path next to the back arrow. What happens instead of that? It just shows "file://", including in the query parameter for Site Details. Additionally, it won't show the same permissions as Page Info will for that file path's permissions. It looks like the root cause for this is that the PermissionManager / GURL::GetOrigin() doesn't support file:// URLs, though HostContentSettingsMap does, which is why it works in Page Info. Note that file:// paths should all be treated as their own origin (permissions are scoped to a single file).
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f083d2363247abc9082cbc0f337e2efec4585fc commit 5f083d2363247abc9082cbc0f337e2efec4585fc Author: Patti <patricialor@chromium.org> Date: Thu Sep 07 02:13:19 2017 MD Settings: If on a file:// URL, don't navigate to Site Details via Page Info. PermissionManager doesn't seem to support retrieving permission settings for file:// scheme URLs, which means Site Details won't either. Temporarily disable navigation to Site Details from a file:// URL until https://crbug.com/444047 can be fixed. Bug: 656758 , 444047, 762751 Change-Id: Ib12f0990e22e26e20706e976a6cb21c6def70c7d Reviewed-on: https://chromium-review.googlesource.com/647355 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#500188} [modify] https://crrev.com/5f083d2363247abc9082cbc0f337e2efec4585fc/chrome/browser/ui/page_info/page_info.cc [modify] https://crrev.com/5f083d2363247abc9082cbc0f337e2efec4585fc/chrome/browser/ui/views/page_info/page_info_bubble_view_browsertest.cc
,
Sep 7 2017
,
Sep 8 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10d0030fda6c0c115df95fc51c114d9b59769403 commit 10d0030fda6c0c115df95fc51c114d9b59769403 Author: Patti <patricialor@chromium.org> Date: Fri Sep 08 04:14:35 2017 MD Settings: If on a file:// URL, don't navigate to Site Details via Page Info. PermissionManager doesn't seem to support retrieving permission settings for file:// scheme URLs, which means Site Details won't either. Temporarily disable navigation to Site Details from a file:// URL until https://crbug.com/444047 can be fixed. TBR=patricialor@chromium.org (cherry picked from commit 5f083d2363247abc9082cbc0f337e2efec4585fc) Bug: 656758 , 444047, 762751 Change-Id: Ib12f0990e22e26e20706e976a6cb21c6def70c7d Reviewed-on: https://chromium-review.googlesource.com/647355 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500188} Reviewed-on: https://chromium-review.googlesource.com/656864 Reviewed-by: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#83} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/10d0030fda6c0c115df95fc51c114d9b59769403/chrome/browser/ui/page_info/page_info.cc [modify] https://crrev.com/10d0030fda6c0c115df95fc51c114d9b59769403/chrome/browser/ui/views/page_info/page_info_bubble_view_browsertest.cc
,
Nov 10 2017
,
Feb 18 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by patricia...@chromium.org
, Sep 7 2017