New issue
Advanced search Search tips

Issue 762750 link

Starred by 1 user
Status: Fixed
Owner:
rkjnsn@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

IDS_SHARE_CONFIRM_DIALOG_CONFIRM should have a meaning tag

Project Member Reported by rkjnsn@chromium.org, Sep 7 2017 
The confirm button has the text "Share" in English, but doesn't match other usages of "Share" in Chromium. It's more of an accept/confirm button here, rather than an action the user may choose to initiate. Thus, it should have a unique entry in the translation console, which can be accomplished using a meaning tag.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f602bfc8bc7cbfc6cf5aab65cfe005cbe5528ac

commit 8f602bfc8bc7cbfc6cf5aab65cfe005cbe5528ac
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Thu Sep 07 23:58:23 2017

Add message for "Share" in accept/confirm context

"Share" is usually used as an action meaning "send this item to a person
or group of people". For our confirmation dialog, we mean "accept this
incoming connection", which might have a different translation in some
languages.

This CL adds a new message with a meaning tag to trigger a new
translation. Once translation is complete, the old message can be
replaced.

Bug:  762750 
Change-Id: Iba944dc3627b2f88c5bf901bda4d4776d7e97c45
Reviewed-on: https://chromium-review.googlesource.com/654398
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500442}
[modify] https://crrev.com/8f602bfc8bc7cbfc6cf5aab65cfe005cbe5528ac/remoting/resources/remoting_strings.grd
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93df3f7be7c6954abf0ae42290a5c5578652ba43

commit 93df3f7be7c6954abf0ae42290a5c5578652ba43
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Fri Oct 27 21:11:57 2017

Use new "Share" string, now that it's been translated.

Bug:  762750 
Change-Id: If5f943823f53fe56c573bcd3b4b756f02795e0fd
Reviewed-on: https://chromium-review.googlesource.com/707835
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512287}
[modify] https://crrev.com/93df3f7be7c6954abf0ae42290a5c5578652ba43/remoting/resources/remoting_strings.grd

Comment 3 by rkjnsn@chromium.org, Oct 27 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment