Files app (accessibility): Only speak file name + date once on tap/select |
|||||||||||||
Issue descriptionRight now, you focus a file, then double tap and hold to select it, then you hear the full verbalization twice -- first just the whole file name and date, then the whole file name and date again and then "selected". Would be great to have the whole file name and date only read once to not add so much chatter. Logging from touch interactions accessibility review (crbug.com/744982)
,
Oct 17 2017
Based on the investigation so far, I think this happens when selecting the first item both in the check-select mode or single-select mode.
,
Nov 16 2017
,
Dec 8 2017
,
Jan 31 2018
,
Feb 2 2018
,
Feb 2 2018
,
Feb 16 2018
<files-triage>
,
Feb 28 2018
,
Feb 28 2018
,
Feb 28 2018
,
Mar 19 2018
I'm triaging a11y bugs. I have reproduced this bug. I'm not fixing this yet, I'll came back to it later. The issue depends on the view mode (list view or thumbnail view). List view: it indeed can read more than once and can also include the file name and other columns (Size, Type and Date Modified). Thumbnail: It doesn't read the file name upon selection.
,
Mar 26 2018
Upon further investigation, the double read is actually a feature of Chromevox. First it reads what was focused and when double tapped it actually issues the "click", which finally selects the file, then Chromevox reads that the file has been selected. An potential improvement is to reduce the text read on list view, to only read the file name instead of reading all columns, but having all info read is also useful, thus I'm NOT changing this. I noticed an tap issue when using tap+Chromevox on thumbnail view which I'm fixing here. See attachment for fix in action.
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea06a0aca66f1f5b3589e6bacb010b6f475526b8 commit ea06a0aca66f1f5b3589e6bacb010b6f475526b8 Author: Luciano Pacheco <lucmult@chromium.org> Date: Wed Mar 28 00:00:19 2018 A11y add aria label on image on thumbnail view Add id attribute for element that contains the file/directory name to be able to use as label on thumbnail image. Add aria-labelledby attribute to allow Chromevox/screen reader to read file/directory name when the file is selected via tap on thumbnail. See crbug.com/762748#c13 for screencast of fix in action. Bug: 762748 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ida1410d0ce99ad69f6857a61c508c160f7cedd05 Reviewed-on: https://chromium-review.googlesource.com/979898 Reviewed-by: Sasha Morrissey <sashab@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#546322} [modify] https://crrev.com/ea06a0aca66f1f5b3589e6bacb010b6f475526b8/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
,
Apr 12 2018
,
Apr 23 2018
The change from crbug.com/762749 actually changed the behviour of Chromevox for this issue too. Now it doesn't read the last time for "selected". I changed to enforce what exact content is used for accessibility for this element. For list view it adds the |id| of 3 columns entry-name, size and modified date. For grid view it only adds the |id| of entry-name. See screenshot attached.
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf7712419dfe0adf9242434c2edda5db4b9c4a82 commit cf7712419dfe0adf9242434c2edda5db4b9c4a82 Author: Luciano Pacheco <lucmult@chromium.org> Date: Fri Apr 27 03:02:51 2018 Add aria-labelledby to entry element This enforces the exact text that will be read by Chromevox, before this patch it was reading the whole text content from the element which was getting duplicated text. The attribute aria-labelledby is a list of ids of elements whose whose content is used as label by screen reader/Chromevox. For list view it adds the |id| of 3 columns: entry-name, size and modified date. For grid view it only adds the |id| of entry-name. See crbug.com/762748 for screenshots of this change. Bug: 762748 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I58414b4d3115e9854e7599a74da70a5e56060aa4 Reviewed-on: https://chromium-review.googlesource.com/1023501 Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#554278} [modify] https://crrev.com/cf7712419dfe0adf9242434c2edda5db4b9c4a82/ui/file_manager/file_manager/foreground/js/ui/file_grid.js [modify] https://crrev.com/cf7712419dfe0adf9242434c2edda5db4b9c4a82/ui/file_manager/file_manager/foreground/js/ui/file_table.js
,
Apr 27 2018
Fixed for grid and list view. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by yamaguchi@chromium.org
, Oct 17 2017