NetInfo change method is not triggered on desktop when there is a change in the network quality |
||||||
Issue descriptionIt is not triggered because it is currently conditioned behind RuntimeEnabledFeatures::NetInfoDownlinkMaxEnabled(). That check should be removed.
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/113f83e4eb61250981902bb8b82662198a7185c2 commit 113f83e4eb61250981902bb8b82662198a7185c2 Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Sep 08 21:28:24 2017 Trigger change event when there is a change in the network quality The change event is now triggered even when NetInfoDownlinkMaxEnabled() returns false. Bug: 762740 Change-Id: Icb7be612785873c7db5f7523f090235c30053129 Reviewed-on: https://chromium-review.googlesource.com/654221 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#500685} [modify] https://crrev.com/113f83e4eb61250981902bb8b82662198a7185c2/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation-expected.txt [modify] https://crrev.com/113f83e4eb61250981902bb8b82662198a7185c2/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation.html [modify] https://crrev.com/113f83e4eb61250981902bb8b82662198a7185c2/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
,
Sep 8 2017
,
Sep 11 2017
,
Sep 11 2017
The NextAction date has arrived: 2017-09-11
,
Sep 11 2017
Thanks for the fix - can you please confirm if the fix is verified in Canary?
,
Sep 11 2017
Re #6: Yes, verified on Mac OSX that the fix works.
,
Sep 12 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce950005379daad599910eaa90a692ef7c5f6157 commit ce950005379daad599910eaa90a692ef7c5f6157 Author: Tarun Bansal <tbansal@chromium.org> Date: Tue Sep 12 04:02:43 2017 Trigger change event when there is a change in the network quality The change event is now triggered even when NetInfoDownlinkMaxEnabled() returns false. Bug: 762740 Change-Id: Icb7be612785873c7db5f7523f090235c30053129 Reviewed-on: https://chromium-review.googlesource.com/654221 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500685}(cherry picked from commit 113f83e4eb61250981902bb8b82662198a7185c2) Reviewed-on: https://chromium-review.googlesource.com/662245 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#157} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/ce950005379daad599910eaa90a692ef7c5f6157/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation-expected.txt [modify] https://crrev.com/ce950005379daad599910eaa90a692ef7c5f6157/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation.html [modify] https://crrev.com/ce950005379daad599910eaa90a692ef7c5f6157/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
,
Sep 12 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbansal@chromium.org
, Sep 7 2017