New issue
Advanced search Search tips

Issue 762728 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 726187
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Inputs and Dropdowns are 24, not 28

Project Member Reported by bettes@chromium.org, Sep 6 2017

Issue description

Chrome Version: Canary 63.03 

 
Screen Shot 2017-09-06 at 4.13.42 PM.png
82.4 KB View Download
Owner: tapted@chromium.org
Status: Assigned (was: Available)
Maybe we're insetting for the 2 DIP focus ring?

We have to be careful about both sizing and positioning (of other objects relative to these) if focus rings are outset from the nominal control bounds, since I think then the "real" control bounds have to include them.

Or maybe there's another cause here.  Trent investigated checkbox focus rings, so I think it makes sense for him to look at this too.
Mergedinto: 726187
Status: Duplicate (was: Assigned)
I have a fix for this in https://chromium-review.googlesource.com/c/chromium/src/+/607755 

(my Windows machine has been really unhappy lately, talking to gerrit in particular)

That CL uses the layout code that http-auth is using to get the textfield heights correct. So if http-auth looks right, I think this will be handled correctly 
(as for all other dialogs we switch over to using textfield_layout.h).

http://httpbin.org/basic-auth/user/passwd -> attached

Screen Shot 2017-09-07 at 9.40.53 am.png
32.5 KB View Download
http auth looks to be correct! thanks

Sign in to add a comment