New issue
Advanced search Search tips

Issue 762721 link

Starred by 1 user
Status: Fixed
Owner:
rkjnsn@chromium.org
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Native messaging host needs to pass --config option when using --get-status

Project Member Reported by rkjnsn@chromium.org, Sep 6 2017 
The original CL to use the config file name when checking if the daemon is running updated the native messaging host to pass --config when using --stop and --reload, but missed the --get-status case.

This can result in the client believing the host is not running when it is.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a4b71db57554e5ad5e7f1a4571cb2e1410a6b37

commit 6a4b71db57554e5ad5e7f1a4571cb2e1410a6b37
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Wed Sep 06 23:46:57 2017

Include config path for --get-status call

Bug:  762721 
Change-Id: Ie41c1d6f71cb8607e355eb1a3af0ebb673453e35
Reviewed-on: https://chromium-review.googlesource.com/654237
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500129}
[modify] https://crrev.com/6a4b71db57554e5ad5e7f1a4571cb2e1410a6b37/remoting/host/setup/daemon_controller_delegate_linux.cc

Comment 2 by rkjnsn@chromium.org, Sep 7 2017

Labels: Merge-Request-62
Requesting merge as this is a regression introduced just before the branch point. The fix is small and low risk.

Comment 3 by rkjnsn@chromium.org, Sep 7 2017 

Note, original CL is here: https://crrev.com/c/636863
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 8 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 8 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c67eb150862619fd933c0b74f74a6ccdddce6f0

commit 9c67eb150862619fd933c0b74f74a6ccdddce6f0
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Fri Sep 08 21:22:37 2017

Include config path for --get-status call

Bug:  762721 
Change-Id: Ie41c1d6f71cb8607e355eb1a3af0ebb673453e35
Reviewed-on: https://chromium-review.googlesource.com/654237
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500129}(cherry picked from commit 6a4b71db57554e5ad5e7f1a4571cb2e1410a6b37)
Reviewed-on: https://chromium-review.googlesource.com/657741
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#97}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/9c67eb150862619fd933c0b74f74a6ccdddce6f0/remoting/host/setup/daemon_controller_delegate_linux.cc

Comment 6 by rkjnsn@chromium.org, Sep 11 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment