New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762713 link

Starred by 1 user
Status: Fixed
Owner:
cjgrant@chromium.org
Closed: Sep 2017
Cc:
billorr@chromium.org
█ vollick@chromium.org
cjgrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

VR: Split build flags for enable_android_vr and enable_vr

Project Member Reported by mthiesse@chromium.org, Sep 6 2017 
Currently building our desktop unittests is failing because turning on enable_vr for desktop causes some android-only code in places like device/BUILD.gn to (try to) get built.

We should be able to turn the cross-platform VR code on independently from the android-only VR code.

Comment 1 by ddorwin@chromium.org, Sep 6 2017

Cc: billorr@chromium.org
Labels: VR-Desktop
See also  issue 731802 .

We shouldn't need a flag for a platform - we should be able to use existing mechanisms for that.

Comment 2 by cjgrant@chromium.org, Sep 7 2017

Owner: cjgrant@chromium.org
Status: Assigned (was: Available)
To clarify, we're talking about Linux unit tests here, correct?  Bill was working on making them work on Windows as well.

Ian landed https://chromium-review.googlesource.com/c/chromium/src/+/653739 last night, which fixes Linux.  Michael, does that whack this bug from your perspective?

Comment 3 by mthiesse@chromium.org, Sep 7 2017

Status: Fixed (was: Assigned)
Yeah I think this wacks this bug.

Comment 4 by btebbs@chromium.org, Jul 4

Components: Internals>XR
►

Sign in to add a comment