New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762704 link

Starred by 1 user
Status: Fixed
Owner:
chanli@chromium.org
Closed: Sep 2017
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] try to use analysis entity before creation.

Project Member Reported by chanli@chromium.org, Sep 6 2017 
Failure log: https://pantheon.corp.google.com/errors/15145489336668462293?time=P30D&filter&project=findit-for-me

Basically because of my last change https://chromium-review.googlesource.com/c/infra/infra/+/620008, analysis on the current failed build is before build_failure_analysis_pipelines.NeedANewAnalysis. But since NeedANewAnalysis is where we create new WfAnalysis entities
for new analysis, this change introduced a bug where we use the analysis entity when it's not created yet.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d76c5734ebf5ab8ec54bd6bf67b058af7d461316

commit d76c5734ebf5ab8ec54bd6bf67b058af7d461316
Author: Chan <chanli@chromium.org>
Date: Thu Sep 07 17:26:59 2017

[Findit] Fix bug when analysis current failure.

Because of my last change https://chromium-review.googlesource.com/c/infra/infra/+/620008, analysis on the current failed build is before build_failure_analysis_pipelines.NeedANewAnalysis. But since NeedANewAnalysis is where we create new WfAnalysis entities
for new analysis, this change introduced a bug where we use the analysis entity when it's not created yet.

This CL fixes the bug by analyzing on current failed build after NeedANewAnalysis (which means entity is created or reset), and still
keep the functionality to bail out if the failure is not really failed or some required information is missing.

Bug:  762704 
Change-Id: Ic1ebbcfd6ba8faacc4884633b012600b67911c20
Reviewed-on: https://chromium-review.googlesource.com/654065
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/d76c5734ebf5ab8ec54bd6bf67b058af7d461316/appengine/findit/services/ci_failure.py
[modify] https://crrev.com/d76c5734ebf5ab8ec54bd6bf67b058af7d461316/appengine/findit/waterfall/build_failure_analysis_pipelines.py
[modify] https://crrev.com/d76c5734ebf5ab8ec54bd6bf67b058af7d461316/appengine/findit/services/test/ci_failure_test.py
[modify] https://crrev.com/d76c5734ebf5ab8ec54bd6bf67b058af7d461316/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py
[modify] https://crrev.com/d76c5734ebf5ab8ec54bd6bf67b058af7d461316/appengine/findit/handlers/test/build_failure_test.py

Comment 2 by chanli@chromium.org, Sep 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment