New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762694 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 642513

Blocking:
issue 879434


Participants' hotlists:
Hotlist-Files-Touch

Show other hotlists

Other hotlists containing this issue:
Fixing-touch


Sign in to add a comment

Open soft keyboard when saving file in tablet mode

Project Member Reported by mcirimele@chromium.org, Sep 6 2017

Issue description

Chrome Version: 63.0.3206.0 9916.0.0 Kevin

What steps will reproduce the problem?
(1) Put device in tablet mode.
(2) Save a file from the browser or similar

What is the expected result?
The "Save as" window opens with the soft keyboard out. The user can see the content of the current folder above the soft keyboard. 

What happens instead?
The soft keyboard does not open. When I tap to open it the content of the files app is no longer shown. 

Video: https://drive.google.com/open?id=11beRpXkDNmLgWIoTdqmGiUXMePCS1SkNuQ
 

Comment 1 by fukino@chromium.org, Oct 18 2017

Blockedon: 642513
Cc: oka@chromium.org
Labels: -M-63 M-65
Labels: -M-65 M-66
Owner: ----
Status: Available (was: Untriaged)

Comment 5 by sashab@chromium.org, Feb 16 2018

Labels: CrOS-FilesApp-Touch
<files-triage>

Comment 6 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-Touch CrOSFilesCategory-Touch
Labels: M-69
Labels: -M-66

Comment 9 by loyso@chromium.org, Apr 9 2018

Labels: -Pri-3 Pri-2
Labels: OS-Chrome
Owner: noel@chromium.org
Status: Assigned (was: Available)

Comment 12 by loyso@chromium.org, Jun 21 2018

The interesting corner case:
(1) Put device in clamshell mode.
(2) Save a file from the browser or similar
(3) The "Save as" window opens without the soft keyboard out. "Filename" input element has a focus (the bold underline)
(4) Put device in tablet mode while "Filename" has a focus
(5) The on screen keyboard should pop-up *
(6) User should be able to cut/paste text selection with blue touch handles *

* = Doesn't happen.

Comment 13 by oka@chromium.org, Jun 21 2018

Cc: -oka@chromium.org
Labels: -Pri-2 -M-69 M-70 Pri-1
in M70 dev on eve:

#12 step 5) when the device is in tablet mode, focus the input element with touch and ... the on-screen keyboard pops-up.
In M70 dev on eve:

(1) Put device in tablet mode
(2) Save a file from the browser or some other app (Text in my case)
 (2a) save dialog appears
(3) focus the "save as" field on the dialog using touch
 (3b) the on-screen keyboard appears
(4) enter the file name using the the on-screen keyboard
(5) the file is save with that name


In M70 dev on eve:

1) Open Files app in tablet mode.
2) use 2 finger press on a file
 2a) the file context menu is shown
3)_Select the "rename" context menu
 3a) a text input field appears
4) touch that input field
 4a) the on-screen keyboard appears

Status: Fixed (was: Assigned)
Seems like this issue has been fixed, outside of Files App as expected. 

The component layers of chrome deal with special assist for WebContent (web pages, chrome extensions, or apps) input elements.


I can still repro the original but on Kevin M70. 

When I filed this my opinion was that the keyboard should open automatically. I no longer think that is true, the user should be able to save whatever default file name if they would like. However, when the keyboard opens it automatically pushes the file picker window up (it looks like) so I can no longer see the top of the window which is where the directory tree is. 

Could we overlay the soft keyboard without moving the place in the file picker?
> I can still repro the original but on Kevin M70. 

Tried on Kevin and no repro for me.  Still not working for you?

>When I filed this my opinion was that the keyboard should open automatically. I no longer think that is true, the user should be able to save whatever default file name if they would like.

https://cs.chromium.org/chromium/src/content/renderer/render_widget.cc?rcl=75dd162683c8885834e075778314451ce5ee23ca&l=2110

  // On ChromeOS, virtual keyboard is triggered only when users leave the
  // mouse button or the finger and a text input element is focused at that
  // time. Focus event itself shouldn't trigger virtual keyboard.

What this means is that Blink must be processing a user gesture: mouse up, or tap up, and there is focused <input> element on the web page.

https://cs.chromium.org/chromium/src/content/renderer/input/render_widget_input_handler.cc?rcl=a29d09e5d5b9b8ca261f4e2c84a9f77eb4d03a12&l=426

so user needs to tap or click.

> However, when the keyboard opens it automatically pushes the file picker window up (it looks like) so I can no longer see the top of the window which is where the directory tree is.

Yes, it scrolls the <input> element into view so the user can type a file name :)

> Could we overlay the soft keyboard without moving the place in the file picker?

Maybe, but user would then need to manually scroll to bring the <input> into view, right?
Cc: slangley@chromium.org
Main thing I noticed was not one test squeaked.  Filed 879434 about adding some VK tests to cover the basics as in this report. 

Ahem issue 879434.
Blocking: 879434
> However, when the keyboard opens it automatically pushes the file picker window up (it looks like) so I can no longer see the top of the window which is where the directory tree is.
Yes, it scrolls the <input> element into view so the user can type a file name :)

> Could we overlay the soft keyboard without moving the place in the file picker?
Maybe, but user would then need to manually scroll to bring the <input> into view, right?

Sure, that's fair. I suppose another way to put it is: When the VK is open the user should be able to see the <input> field as well as be able to access the tree directory (top of Files app) at the same time. Is there a way for us to achieve that? One part of "Save as" is to specify a file name, one is to choose the destination, it would be great if those were both equally accessible. 
Cc: weifangsun@chromium.org
+Weifang FYI and prioritization. 

Sign in to add a comment