New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762691 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Change Files app window title in overview

Project Member Reported by mcirimele@chromium.org, Sep 6 2017

Issue description

Chrome Version: 63.0.3206.0 9916.0.0 Kevin

In overview the Files app window depends on what folder is currently open. It makes it hard to identify it as the Files app. We should change it. There are no guidelines for how to set the title, apps do it differently. 

I suggest we use:
Files - [name of current folder] 

Example: 
Files - Recent
 
Screenshot 2017-09-06 at 1.48.57 PM.png
4.0 MB View Download
Labels: -M-63

Comment 2 by sashab@chromium.org, Feb 23 2018

Labels: CrOS-FilesApp-UI Hotlist-GoodFirstBug
Status: Assigned (was: Untriaged)
+Weifang what are the next steps for a bug like this? :)

Comment 3 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-UI CrOSFilesCategory-UI
Labels: Files-Fixit-2018
Cc: weifangsun@chromium.org
Owner: sa...@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0ee32e471ef0735f32bf029aa2b7990565505f6

commit e0ee32e471ef0735f32bf029aa2b7990565505f6
Author: Sam McNally <sammc@chromium.org>
Date: Wed Nov 21 05:55:08 2018

Prefix the files app document title with its localised name.

For example, when viewing Downloads, the title in English would be
"Files - Downloads".

Bug:  762691 
Change-Id: Icb9047da7f5e635db2c845d15e98a3165286689f
Reviewed-on: https://chromium-review.googlesource.com/c/1345712
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609923}
[modify] https://crrev.com/e0ee32e471ef0735f32bf029aa2b7990565505f6/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/e0ee32e471ef0735f32bf029aa2b7990565505f6/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/e0ee32e471ef0735f32bf029aa2b7990565505f6/ui/file_manager/file_manager/foreground/js/main_window_component.js

Status: Fixed (was: Assigned)
 Issue 888579  has been merged into this issue.

Sign in to add a comment