SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/nQl0ORHy7sw/HNpR96sqAgAJ. Cronet has migrated consumers off SDCH and disabled it in M63 ( Issue 755561 ). Filing a bug to remove SDCH code from the codebase.
+rdsmith@, sleevi@, mmenke@: FYI. I will upload a CL. I don't think we have any remaining consumers of SDCH. Let me know if this is not the case.
Thank you for doing this!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d769b5cdecc22a96a599c252c6b37403ca9c472 commit 1d769b5cdecc22a96a599c252c6b37403ca9c472 Author: Helen Li <xunjieli@chromium.org> Date: Mon Sep 11 18:33:37 2017 Remove sdch dependency from //extensions This dependency is not used. Sdch code is being removed from Chromium, see linked bug for more detail. Bug: 762686 Change-Id: Id1b4ffb9c524dcdf1e393390d9fab2719fe19504 Reviewed-on: https://chromium-review.googlesource.com/660377 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#500984} [modify] https://crrev.com/1d769b5cdecc22a96a599c252c6b37403ca9c472/extensions/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7dd80832e3eb15720ba70407a4cefda2420559d9 commit 7dd80832e3eb15720ba70407a4cefda2420559d9 Author: Helen Li <xunjieli@chromium.org> Date: Tue Sep 12 18:29:17 2017 Remove SDCH code from net/url_request/ SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. This CL is to remove sdch code from net/url_request. This is the first CL in the series. Bug: 762686 Change-Id: If467b19a2b963c3790bf372ab278bbf847052ddf Reviewed-on: https://chromium-review.googlesource.com/660999 Reviewed-by: Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501339} [modify] https://crrev.com/7dd80832e3eb15720ba70407a4cefda2420559d9/net/url_request/url_request_context.cc [modify] https://crrev.com/7dd80832e3eb15720ba70407a4cefda2420559d9/net/url_request/url_request_context.h [modify] https://crrev.com/7dd80832e3eb15720ba70407a4cefda2420559d9/net/url_request/url_request_context_builder.cc [modify] https://crrev.com/7dd80832e3eb15720ba70407a4cefda2420559d9/net/url_request/url_request_context_storage.cc [modify] https://crrev.com/7dd80832e3eb15720ba70407a4cefda2420559d9/net/url_request/url_request_context_storage.h [modify] https://crrev.com/7dd80832e3eb15720ba70407a4cefda2420559d9/net/url_request/url_request_http_job.cc [modify] https://crrev.com/7dd80832e3eb15720ba70407a4cefda2420559d9/net/url_request/url_request_http_job.h [modify] https://crrev.com/7dd80832e3eb15720ba70407a4cefda2420559d9/net/url_request/url_request_http_job_unittest.cc [modify] https://crrev.com/7dd80832e3eb15720ba70407a4cefda2420559d9/net/url_request/url_request_test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f88fc4ea71eed44810dda18a1c01ae8cd9d658a4 commit f88fc4ea71eed44810dda18a1c01ae8cd9d658a4 Author: Helen Li <xunjieli@chromium.org> Date: Tue Sep 12 20:04:28 2017 Remove SDCH code from net/filter/ This CL removes SDCH code from net/filter/. This CL is one of the CLs to remove SDCH from Chromium. SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. Bug: 762686 Change-Id: I5d98c0171a4fbceb1348ccc2a67fa2a51bd4df8a Reviewed-on: https://chromium-review.googlesource.com/663239 Reviewed-by: Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501372} [modify] https://crrev.com/f88fc4ea71eed44810dda18a1c01ae8cd9d658a4/net/BUILD.gn [modify] https://crrev.com/f88fc4ea71eed44810dda18a1c01ae8cd9d658a4/net/docs/filter.md [delete] https://crrev.com/5685499bb10100030d43821f098ebd7437286588/net/filter/sdch_policy_delegate.cc [delete] https://crrev.com/5685499bb10100030d43821f098ebd7437286588/net/filter/sdch_policy_delegate.h [delete] https://crrev.com/5685499bb10100030d43821f098ebd7437286588/net/filter/sdch_policy_delegate_unittest.cc [delete] https://crrev.com/5685499bb10100030d43821f098ebd7437286588/net/filter/sdch_source_stream.cc [delete] https://crrev.com/5685499bb10100030d43821f098ebd7437286588/net/filter/sdch_source_stream.h [delete] https://crrev.com/5685499bb10100030d43821f098ebd7437286588/net/filter/sdch_source_stream_unittest.cc [modify] https://crrev.com/f88fc4ea71eed44810dda18a1c01ae8cd9d658a4/net/url_request/url_request_http_job.cc [modify] https://crrev.com/f88fc4ea71eed44810dda18a1c01ae8cd9d658a4/net/url_request/url_request_http_job.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e2d56ae0d02c94578197a5a98896b1752831e10 commit 3e2d56ae0d02c94578197a5a98896b1752831e10 Author: Helen Li <xunjieli@chromium.org> Date: Tue Sep 12 21:36:27 2017 Remove SDCH code from src/chrome/ This CL removes SDCH code from src/chrome/. This CL is one of the CLs to remove SDCH from Chromium. SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. Bug: 762686 Change-Id: If9dbf8ce17aa026f9b0f2ce631669756f4be1e28 Reviewed-on: https://chromium-review.googlesource.com/663621 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501405} [modify] https://crrev.com/3e2d56ae0d02c94578197a5a98896b1752831e10/chrome/browser/BUILD.gn [modify] https://crrev.com/3e2d56ae0d02c94578197a5a98896b1752831e10/chrome/browser/io_thread.cc [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/browser/net/sdch_browsertest.cc [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/browser/net/sdch_owner_pref_storage.cc [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/browser/net/sdch_owner_pref_storage.h [modify] https://crrev.com/3e2d56ae0d02c94578197a5a98896b1752831e10/chrome/test/BUILD.gn [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/test/data/sdch/base-page.html [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/test/data/sdch/dict [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/test/data/sdch/dict.mock-http-headers [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/test/data/sdch/non-html [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/test/data/sdch/non-html.mock-http-headers [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/test/data/sdch/non-sdch.html [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/test/data/sdch/non-sdch.html.mock-http-headers [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/test/data/sdch/page.html [delete] https://crrev.com/ad438915cdcc0cdac9a0badd3a4f74a43a2a99a5/chrome/test/data/sdch/page.html.mock-http-headers
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50a9e59de19d548679effb5cbcbdb43ab63758ad commit 50a9e59de19d548679effb5cbcbdb43ab63758ad Author: Helen Li <xunjieli@chromium.org> Date: Wed Sep 13 14:00:38 2017 Remove SDCH code from storage_partition_http_cache_data_remover.cc SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. The code in storage_partition_http_cache_data_remover.cc is no-op since M59. This CL removes it. Bug: 762686 Change-Id: I283aa34c5c2c1ef13744414aa7bda275b60c7d47 Reviewed-on: https://chromium-review.googlesource.com/663632 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501616} [modify] https://crrev.com/50a9e59de19d548679effb5cbcbdb43ab63758ad/content/browser/browsing_data/storage_partition_http_cache_data_remover.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de4d4300d28af90669ac89c129fe2c4584a0cb1c commit de4d4300d28af90669ac89c129fe2c4584a0cb1c Author: Helen Li <xunjieli@chromium.org> Date: Wed Sep 13 16:35:31 2017 Remove src/net/sdch SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. This CL removes src/net/sdch. histograms will be deprecated in a separate CL. net/ TBR=rdsmith@chromium.org ios/chrome/browser TBR=sdefresne@chromium.org Bug: 762686 Change-Id: Iea2e894c99303912b5f09b5708f9f32dea6bd325 Reviewed-on: https://chromium-review.googlesource.com/664979 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Randy Smith <rdsmith@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501658} [modify] https://crrev.com/de4d4300d28af90669ac89c129fe2c4584a0cb1c/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm [modify] https://crrev.com/de4d4300d28af90669ac89c129fe2c4584a0cb1c/net/BUILD.gn [delete] https://crrev.com/653942c6d1b3e871f3367c0e779ffc01d0948c0d/net/sdch/OWNERS [delete] https://crrev.com/653942c6d1b3e871f3367c0e779ffc01d0948c0d/net/sdch/README.md [delete] https://crrev.com/653942c6d1b3e871f3367c0e779ffc01d0948c0d/net/sdch/sdch_owner.cc [delete] https://crrev.com/653942c6d1b3e871f3367c0e779ffc01d0948c0d/net/sdch/sdch_owner.h [delete] https://crrev.com/653942c6d1b3e871f3367c0e779ffc01d0948c0d/net/sdch/sdch_owner_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d87a483b1f2d2b082d76aff33a09cdc0e4124426 commit d87a483b1f2d2b082d76aff33a09cdc0e4124426 Author: Helen Li <xunjieli@chromium.org> Date: Wed Sep 13 17:41:33 2017 Remove net/url_request/sdch_dictionary_fetcher* SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. This CL removes src/net/url_request/sdch_dictionary_fetcher. histograms will be deprecated in a separate CL. Bug: 762686 Change-Id: I47bf189ffce6b998944105a7f0601a57aa684d95 Reviewed-on: https://chromium-review.googlesource.com/665062 Reviewed-by: Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501681} [modify] https://crrev.com/d87a483b1f2d2b082d76aff33a09cdc0e4124426/net/BUILD.gn [delete] https://crrev.com/006f2532ea48d3f3185baf7c800633aabfccfb96/net/url_request/sdch_dictionary_fetcher.cc [delete] https://crrev.com/006f2532ea48d3f3185baf7c800633aabfccfb96/net/url_request/sdch_dictionary_fetcher.h [delete] https://crrev.com/006f2532ea48d3f3185baf7c800633aabfccfb96/net/url_request/sdch_dictionary_fetcher_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d0635e573b0324e79fa55b9efae0499062aede9 commit 5d0635e573b0324e79fa55b9efae0499062aede9 Author: Helen Li <xunjieli@chromium.org> Date: Thu Sep 14 14:38:02 2017 Mark SDCH histograms as obsolete in histograms.xml SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. This CL is to mark the remaining SDCH histograms as obsolete. Bug: 762686 Change-Id: I8d3e5ebb10ef1add85f715a97cf8f9fbeeee2937 Reviewed-on: https://chromium-review.googlesource.com/665064 Reviewed-by: Randy Smith <rdsmith@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501948} [modify] https://crrev.com/5d0635e573b0324e79fa55b9efae0499062aede9/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14e8ff08516bd1543eec5045d800b9ba74ed7599 commit 14e8ff08516bd1543eec5045d800b9ba74ed7599 Author: Helen Li <xunjieli@chromium.org> Date: Thu Sep 14 19:45:20 2017 Remove SDCH code SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. This CL removes SDCH code from src/net/, net-internals and related test directories. Bug: 762686 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2afb7e98187f9e25107918799cbf94046ef9c853 Reviewed-on: https://chromium-review.googlesource.com/665065 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: Randy Smith <rdsmith@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#502018} [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/browser/net/DEPS [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/browser/resources/net_internals/browser_bridge.js [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/browser/resources/net_internals/index.html [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/browser/resources/net_internals/index.js [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/browser/resources/net_internals/log_view_painter.js [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/browser/resources/net_internals/main.js [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/chrome/browser/resources/net_internals/sdch_view.js [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/test/data/webui/BUILD.gn [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/test/data/webui/net_internals/events_view.js [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/test/data/webui/net_internals/log_util.js [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/test/data/webui/net_internals/log_view_painter.js [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/test/data/webui/net_internals/main.js [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/chrome/test/data/webui/net_internals/net_internals_test.js [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/chrome/test/data/webui/net_internals/sdch_view.js [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/ios/components/io_thread/ios_io_thread.mm [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/ios/net/http_cache_helper.cc [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/net/BUILD.gn [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/net/base/net_info_source_list.h [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_dictionary.cc [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_dictionary.h [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_dictionary_unittest.cc [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_manager.cc [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_manager.h [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_manager_unittest.cc [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_net_log_params.cc [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_net_log_params.h [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_observer.cc [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_observer.h [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_problem_code_list.h [delete] https://crrev.com/d17220483696649dd81013562e1f309543b33885/net/base/sdch_problem_codes.h [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/net/log/net_log_event_type_list.h [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/net/log/net_log_util.cc [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/net/url_request/url_request_context.h [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/net/url_request/url_request_context_builder.h [modify] https://crrev.com/14e8ff08516bd1543eec5045d800b9ba74ed7599/net/url_request/url_request_http_job_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/681f2330ee8c799b5a3eafc13ed9ebf8080a6841 commit 681f2330ee8c799b5a3eafc13ed9ebf8080a6841 Author: Helen Li <xunjieli@chromium.org> Date: Fri Sep 15 14:31:30 2017 Remove src/sdch SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. This CL removes src/net/. Bug: 762686 Change-Id: I30f2c017d0190aa5bf08eb7f9da86dd5f54b4f18 Reviewed-on: https://chromium-review.googlesource.com/667537 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#502246} [modify] https://crrev.com/681f2330ee8c799b5a3eafc13ed9ebf8080a6841/net/BUILD.gn [modify] https://crrev.com/681f2330ee8c799b5a3eafc13ed9ebf8080a6841/net/DEPS [delete] https://crrev.com/47d6522a58399d49d8da7014f98acbba6f84b6b5/sdch/BUILD.gn [delete] https://crrev.com/47d6522a58399d49d8da7014f98acbba6f84b6b5/sdch/OWNERS [delete] https://crrev.com/47d6522a58399d49d8da7014f98acbba6f84b6b5/sdch/README.chromium [delete] https://crrev.com/47d6522a58399d49d8da7014f98acbba6f84b6b5/sdch/bsd/config.h [delete] https://crrev.com/47d6522a58399d49d8da7014f98acbba6f84b6b5/sdch/ios/config.h [delete] https://crrev.com/47d6522a58399d49d8da7014f98acbba6f84b6b5/sdch/linux/config.h [delete] https://crrev.com/47d6522a58399d49d8da7014f98acbba6f84b6b5/sdch/logging_forward.h [delete] https://crrev.com/47d6522a58399d49d8da7014f98acbba6f84b6b5/sdch/mac/config.h [delete] https://crrev.com/47d6522a58399d49d8da7014f98acbba6f84b6b5/sdch/win/config.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7c9b6b8ca3c5faaf0a5fb006b24e2bb92af7e7a commit d7c9b6b8ca3c5faaf0a5fb006b24e2bb92af7e7a Author: Helen Li <xunjieli@chromium.org> Date: Fri Sep 15 16:36:14 2017 Remove URLRequestJob::DestroySourceStream() SdchSourceStream is gone. This method is no longer needed. Bug: 762686 Change-Id: Ieb85ed958a803781717c1144139a3111ed534c5e Reviewed-on: https://chromium-review.googlesource.com/667328 Reviewed-by: Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#502279} [modify] https://crrev.com/d7c9b6b8ca3c5faaf0a5fb006b24e2bb92af7e7a/net/url_request/url_request_http_job.cc [modify] https://crrev.com/d7c9b6b8ca3c5faaf0a5fb006b24e2bb92af7e7a/net/url_request/url_request_job.cc [modify] https://crrev.com/d7c9b6b8ca3c5faaf0a5fb006b24e2bb92af7e7a/net/url_request/url_request_job.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/666c068451e48641d613f4470bb7a151b3ca21d8 commit 666c068451e48641d613f4470bb7a151b3ca21d8 Author: Helen Li <xunjieli@chromium.org> Date: Fri Sep 15 19:57:05 2017 Deprecate SDCH-related net::SourceStream types - Deprecated three SDCH-related net::SourceStream types - Modify URLRequestHttpJob::SetUpSourceStream() to not include default case Bug: 764434 , 764433 , 762686 Change-Id: I93320bfee930484da76a0a29fab2224f2b886523 Reviewed-on: https://chromium-review.googlesource.com/667731 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#502337} [modify] https://crrev.com/666c068451e48641d613f4470bb7a151b3ca21d8/net/filter/filter_source_stream.cc [modify] https://crrev.com/666c068451e48641d613f4470bb7a151b3ca21d8/net/filter/gzip_source_stream.cc [modify] https://crrev.com/666c068451e48641d613f4470bb7a151b3ca21d8/net/filter/gzip_source_stream.h [modify] https://crrev.com/666c068451e48641d613f4470bb7a151b3ca21d8/net/filter/gzip_source_stream_fuzzer.cc [modify] https://crrev.com/666c068451e48641d613f4470bb7a151b3ca21d8/net/filter/gzip_source_stream_unittest.cc [modify] https://crrev.com/666c068451e48641d613f4470bb7a151b3ca21d8/net/filter/source_stream_type_list.h [modify] https://crrev.com/666c068451e48641d613f4470bb7a151b3ca21d8/net/url_request/url_request_http_job.cc [modify] https://crrev.com/666c068451e48641d613f4470bb7a151b3ca21d8/net/url_request/url_request_http_job_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8de46a4ca68871229527c93843b3cd2de3d41f1a commit 8de46a4ca68871229527c93843b3cd2de3d41f1a Author: Helen Li <xunjieli@chromium.org> Date: Tue Sep 19 13:50:39 2017 Remove vcdiff from src/DEPS vcdiff dependency is used for SDCH. SDCH has been disabled in Chrome in M59. This CL removes vcdiff dependency from src/DEPS. TBR=jochen@chromium.org Bug: 762686 Change-Id: I836e501c09900c4d49bf742a5b430d3e586a3a66 Reviewed-on: https://chromium-review.googlesource.com/671147 Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#502842} [modify] https://crrev.com/8de46a4ca68871229527c93843b3cd2de3d41f1a/DEPS
I also removed SDCH code from catapult/netlog_viewer. Didn't staple the bug correctly, so I will post it here. CL: https://codereview.chromium.org/3011363002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87e697db77ee2309a0821cb9f8afb26f326449de commit 87e697db77ee2309a0821cb9f8afb26f326449de Author: Helen Li <xunjieli@chromium.org> Date: Tue Sep 19 20:05:20 2017 Remove sdch mention from src/DEPS TBR=rdsmith@chromium.org Bug: 762686 Change-Id: I644d345d283528b417a5a8398bf40530a8ace1f7 Reviewed-on: https://chromium-review.googlesource.com/673095 Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#502930} [modify] https://crrev.com/87e697db77ee2309a0821cb9f8afb26f326449de/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/933071e48a47887e8b728b8183af8391125ee4ff commit 933071e48a47887e8b728b8183af8391125ee4ff Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Tue Sep 19 21:21:16 2017 Roll src/third_party/catapult/ 8380d62bc..ab30bb20a (2 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8380d62bc249..ab30bb20a857 $ git log 8380d62bc..ab30bb20a --date=short --no-merges --format='%ad %ae %s' 2017-09-19 xunjieli Apply Chromium changes up to commit 0036296a1128ac9cbefeaff51c8df831ec421c36 2017-09-19 nednguyen Roll tsproxy to the latest version Created with: roll-dep src/third_party/catapult BUG= #762686 , 764825 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I95d0f20d306fbba29c1ebcc63bb0db563e367c4a Reviewed-on: https://chromium-review.googlesource.com/673380 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502951} [modify] https://crrev.com/933071e48a47887e8b728b8183af8391125ee4ff/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1eb2cae571a02a2c71c7a611d429840e96cce344 commit 1eb2cae571a02a2c71c7a611d429840e96cce344 Author: Helen Li <xunjieli@chromium.org> Date: Wed Sep 20 00:03:02 2017 [cronet] Remove SDCH mention from cronet docs Bug: 762686 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ib1d74e81add02200727d4171c5cd398841da83bb Reviewed-on: https://chromium-review.googlesource.com/673269 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#502996} [modify] https://crrev.com/1eb2cae571a02a2c71c7a611d429840e96cce344/components/cronet/README.md [modify] https://crrev.com/1eb2cae571a02a2c71c7a611d429840e96cce344/components/cronet/android/api/src/org/chromium/net/CronetEngine.java [modify] https://crrev.com/1eb2cae571a02a2c71c7a611d429840e96cce344/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java [modify] https://crrev.com/1eb2cae571a02a2c71c7a611d429840e96cce344/components/cronet/android/java/src/org/chromium/net/impl/NativeCronetEngineBuilderImpl.java [modify] https://crrev.com/1eb2cae571a02a2c71c7a611d429840e96cce344/components/cronet/android/java/src/org/chromium/net/impl/NativeCronetEngineBuilderWithLibraryLoaderImpl.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7c854cea76c9d5c034a8b26b5f687938b5e3a0a commit d7c854cea76c9d5c034a8b26b5f687938b5e3a0a Author: Helen Li <xunjieli@chromium.org> Date: Wed Sep 20 15:28:32 2017 Remove chrome/browser/resources/net_internals/sdch_view.html This is a follow-up of r14e8ff08516bd1543eec5045d800b9ba74ed7599, which missed the deletion of this file. TBR=eroman@chromium.org Bug: 762686 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I66dfda4735ea6ae72ca7a240bfd22ad630305b16 Reviewed-on: https://chromium-review.googlesource.com/674347 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#503150} [delete] https://crrev.com/3ec10d4a0dbd347df011c97f9f6b637dee0750d4/chrome/browser/resources/net_internals/sdch_view.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcdc7ba645a5c12c7d8fbfed8bdf2c86fcad13d1 commit bcdc7ba645a5c12c7d8fbfed8bdf2c86fcad13d1 Author: Helen Li <xunjieli@chromium.org> Date: Wed Sep 20 15:32:47 2017 Remove sdch from a few files SDCH code has been disabled in Chrome since M59. SDCH code is being removed from Chrome in M63. This CL is to remove it from .gn, .gitignore, licenses.py and check_gn_headers_whitelist.txt. Bug: 762686 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng Change-Id: I0986a75b548fd6c1ec2e6806a8f6cd38ad2058f6 Reviewed-on: https://chromium-review.googlesource.com/674666 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#503153} [modify] https://crrev.com/bcdc7ba645a5c12c7d8fbfed8bdf2c86fcad13d1/.gitignore [modify] https://crrev.com/bcdc7ba645a5c12c7d8fbfed8bdf2c86fcad13d1/.gn [modify] https://crrev.com/bcdc7ba645a5c12c7d8fbfed8bdf2c86fcad13d1/build/check_gn_headers_whitelist.txt [modify] https://crrev.com/bcdc7ba645a5c12c7d8fbfed8bdf2c86fcad13d1/tools/licenses.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/923e8d72c6b657763fa73c51737b2d81e5d7c348 commit 923e8d72c6b657763fa73c51737b2d81e5d7c348 Author: Helen Li <xunjieli@chromium.org> Date: Wed Sep 20 16:06:08 2017 Remove SDCH mention from net/docs Bug: 762686 Change-Id: I84c9b711506bfaa70f954a772180fff9eee0276b Reviewed-on: https://chromium-review.googlesource.com/675165 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#503167} [modify] https://crrev.com/923e8d72c6b657763fa73c51737b2d81e5d7c348/net/docs/bug-triage-labels.md [modify] https://crrev.com/923e8d72c6b657763fa73c51737b2d81e5d7c348/net/docs/life-of-a-feature.md [modify] https://crrev.com/923e8d72c6b657763fa73c51737b2d81e5d7c348/net/docs/life-of-a-url-request.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81f8d43291739e236f21fa12da0e3573bf77c1be commit 81f8d43291739e236f21fa12da0e3573bf77c1be Author: Helen Li <xunjieli@chromium.org> Date: Wed Sep 20 20:55:20 2017 Remove sdch_manager from memory_infra_background_whitelist.cc SDCH code has been disabled in Chrome since M59. SDCH code is removed from Chrome in M63. This CL is to remove it from memory infra whitelist. Bug: 762686 Change-Id: Ib1a38a0d297108c3eaaed2d1fe75711519d579bb Reviewed-on: https://chromium-review.googlesource.com/672904 Reviewed-by: Siddhartha S <ssid@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#503243} [modify] https://crrev.com/81f8d43291739e236f21fa12da0e3573bf77c1be/base/trace_event/memory_infra_background_whitelist.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/765359e6693ed95143e09a9693895d828ad31ad5 commit 765359e6693ed95143e09a9693895d828ad31ad5 Author: Helen Li <xunjieli@chromium.org> Date: Thu Sep 21 19:13:44 2017 Sdch cleanup src/sdch directory is gone. This CL cleans up the reference. Bug: 762686 Change-Id: I5e5a501c96b8e4d35ebad3afbf1295f06e610d91 Reviewed-on: https://chromium-review.googlesource.com/677277 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#503528} [modify] https://crrev.com/765359e6693ed95143e09a9693895d828ad31ad5/tools/clang/plugins/ChromeClassTester.cpp
I think I have removed all SDCH code that I can find. The code search index is a bit stale: https://cs.chromium.org/search/?q=sdch+-file:src/sdch&sq=package:chromium&type=cs I have left tools/gyp/samples/samples alone because that file is not touched since 2009.
Comment 1 by xunji...@chromium.org
, Sep 6 2017Owner: xunji...@chromium.org
Status: Assigned (was: Untriaged)