New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762684 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Renaming to empty string should revert to old name and fail silently

Project Member Reported by mcirimele@chromium.org, Sep 6 2017

Issue description

Chrome Version: 63.0.3206.0 9916.0.0 Kevin

What steps will reproduce the problem?
(1) Focus or select a file and open the context menu 
(2) Click "rename"
(3) Enter an empty string

What is the expected result?
The textfield closes and the file name reverts to its original name. 

What happens instead?
A dialog that says "Invalid name" is shown. When I tap OK the dialog closes and the textfield is still open with the empty string, effectively forcing the user to write a name before moving on. 

 
Labels: -M-63 M-64

Comment 2 by fukino@chromium.org, Oct 18 2017

Cc: weifangsun@chromium.org
Owner: fukino@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b80b8a10f9ed3d64f2a742e30fe92330bd786027

commit b80b8a10f9ed3d64f2a742e30fe92330bd786027
Author: Naoki Fukino <fukino@chromium.org>
Date: Mon Oct 23 07:52:28 2017

Files app: Cancel rename operation silently when an empty string is input.

Bug:  762684 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I206ccb9c18438a814a08018ebb2ff58597650c5b
Reviewed-on: https://chromium-review.googlesource.com/725641
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510729}
[modify] https://crrev.com/b80b8a10f9ed3d64f2a742e30fe92330bd786027/ui/file_manager/file_manager/foreground/js/naming_controller.js

Comment 4 by fukino@chromium.org, Oct 23 2017

Status: Fixed (was: Started)

Sign in to add a comment