Remove deprecated cbuidlbot support for --remote and --local. |
||
Issue descriptioncbuildbot no longer needs to support tryjob request logic. Remove it.
,
Sep 13 2017
Can you also update the docs at https://www.chromium.org/chromium-os/build/using-remote-trybots ? Running "cbuildbot" instead of "cros tryjob" out of habit just fails with "ERROR: A buildroot is required to build."
,
Sep 13 2017
Sorry, I put in a friendlier warning, but much produce the errors in the wrong order.
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/cc0ee5205beec0c7c4c176a2b71485f3c6dd9f31 commit cc0ee5205beec0c7c4c176a2b71485f3c6dd9f31 Author: Don Garrett <dgarrett@google.com> Date: Thu Sep 14 02:28:27 2017 cbuildbot: Tweak --local and --remote messages. We recently removed --local and --remote tryjob support from cbuildbot, but the messaging to help people who use the wrong tryjob command didn't work out right. Fix it! BUG= chromium:762676 TEST=run_tests -q Change-Id: I47d39f179a0481ac7fc509b609797ae748587055 Reviewed-on: https://chromium-review.googlesource.com/666005 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Nicolas Norvez <norvez@chromium.org> [modify] https://crrev.com/cc0ee5205beec0c7c4c176a2b71485f3c6dd9f31/scripts/cbuildbot.py [modify] https://crrev.com/cc0ee5205beec0c7c4c176a2b71485f3c6dd9f31/cbuildbot/cbuildbot_unittest.py
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9c3c500bef4eff98ccb0df9aefa99c7e20dbef33 commit 9c3c500bef4eff98ccb0df9aefa99c7e20dbef33 Author: Don Garrett <dgarrett@google.com> Date: Fri Sep 15 03:14:09 2017 remote_try: Remove unused functionality. This library originally worked by committing CLs to manifest-versions, which triggered the trybot waterfall. Now that tryjobs can only be triggered via buildbucket, there is no need to retain that functionality. Also, strip out support for a few other values that can't be specified via cros tryjob. BUG= chromium:762676 TEST=run_tests -q cros tryjob --yes lumpy-compile-only-pre-cq cros tryjob --local --yes lumpy-compile-only-pre-cq Change-Id: I60c9aefc33c0521165b2a2cef1b502f247aa279b Reviewed-on: https://chromium-review.googlesource.com/667799 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/9c3c500bef4eff98ccb0df9aefa99c7e20dbef33/cbuildbot/remote_try.py [modify] https://crrev.com/9c3c500bef4eff98ccb0df9aefa99c7e20dbef33/cli/cros/cros_tryjob.py [modify] https://crrev.com/9c3c500bef4eff98ccb0df9aefa99c7e20dbef33/cbuildbot/remote_try_unittest.py
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/bb965dcefb2100c3fc06f25499be1ae078983914 commit bb965dcefb2100c3fc06f25499be1ae078983914 Author: Don Garrett <dgarrett@google.com> Date: Thu Sep 21 08:07:55 2017 remote_try: Remove more unused stuff. Remove the tryjob format version concept, since it's not used (seems like it hasn't been for a long time). Updated description of the related cbuildbot argument --remote-version, but didn't remove that since old tryjob clients will still send it. Remove a couple of unused URL constants in remote_try. Remove self.cache_key. BUG= chromium:762676 TEST=run_tests -q cros tryjob --yes lumpy-compile-only-pre-cq cros tryjob --yes -g 666141 lumpy-compile-only-pre-cq cros tryjob --yes -p chromiumos/chromite:test_branch lumpy-compile-only-pre-cq Change-Id: I441d04425d012708128f31a958e92a89fdf8db06 Reviewed-on: https://chromium-review.googlesource.com/667794 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/bb965dcefb2100c3fc06f25499be1ae078983914/scripts/cbuildbot.py [modify] https://crrev.com/bb965dcefb2100c3fc06f25499be1ae078983914/cbuildbot/remote_try.py
,
Sep 26 2017
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b433ff2d07f364a5c359984c8169cf2ff423e49d commit b433ff2d07f364a5c359984c8169cf2ff423e49d Author: Don Garrett <dgarrett@google.com> Date: Tue Sep 26 20:36:15 2017 remote_try: Move from cbuildbot/ to lib/ Since this library no longer depends on any cbuildbot specific code, it can now be considered a general library. BUG= chromium:762676 TEST=run_tests -q Change-Id: I3c526dd03a127d3f62f435c0eda17827f76fd94e Reviewed-on: https://chromium-review.googlesource.com/676188 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [rename] https://crrev.com/b433ff2d07f364a5c359984c8169cf2ff423e49d/lib/remote_try_unittest.py [rename] https://crrev.com/b433ff2d07f364a5c359984c8169cf2ff423e49d/lib/remote_try.py [rename] https://crrev.com/b433ff2d07f364a5c359984c8169cf2ff423e49d/lib/remote_try_unittest [modify] https://crrev.com/b433ff2d07f364a5c359984c8169cf2ff423e49d/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/b433ff2d07f364a5c359984c8169cf2ff423e49d/cli/cros/cros_tryjob.py |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 13 2017