^^^
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5061b5996885bcf247fc2ec03bdb2ef02fc8ff4 commit d5061b5996885bcf247fc2ec03bdb2ef02fc8ff4 Author: gogerald <gogerald@google.com> Date: Wed Sep 06 23:39:55 2017 [Payments] Reuse service payment app flag for desktop platforms This is the first step to integrate service worker based payment app on desktop platforms. Bug: 762668 Change-Id: I74043350e87561d4d564bbc3ddd14b99a8468bcf Reviewed-on: https://chromium-review.googlesource.com/653609 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#500117} [modify] https://crrev.com/d5061b5996885bcf247fc2ec03bdb2ef02fc8ff4/chrome/browser/about_flags.cc [modify] https://crrev.com/d5061b5996885bcf247fc2ec03bdb2ef02fc8ff4/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/d5061b5996885bcf247fc2ec03bdb2ef02fc8ff4/chrome/browser/flag_descriptions.h [modify] https://crrev.com/d5061b5996885bcf247fc2ec03bdb2ef02fc8ff4/content/public/common/content_features.cc [modify] https://crrev.com/d5061b5996885bcf247fc2ec03bdb2ef02fc8ff4/content/public/common/content_features.h
Present screenshots:
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8189d525a1814381c6c09aa15c5c8bf29a5c0669 commit 8189d525a1814381c6c09aa15c5c8bf29a5c0669 Author: gogerald <gogerald@google.com> Date: Fri Sep 15 17:52:18 2017 [Payments] Present web payment handlers on Desktop platforms This is the first step to integrate web payment handler. The implementation is behind the flag. Bug: 762668 Change-Id: I175b647495f806d4ea595fb80f05b6d0383e73ed Reviewed-on: https://chromium-review.googlesource.com/657899 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#502299} [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/order_summary_view_controller.h [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_method_view_controller.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_completion_status_metrics_browsertest.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_debit_browsertest.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_dialog_view.h [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_journey_logger_browsertest.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_views_util.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/chrome/browser/ui/views/payments/payment_sheet_view_controller.h [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/DEPS [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/content/BUILD.gn [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/content/payment_request.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/content/payment_request.h [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/content/payment_request_state.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/content/payment_request_state.h [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/content/payment_request_state_unittest.cc [add] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/content/service_worker_payment_instrument.cc [add] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/content/service_worker_payment_instrument.h [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/core/autofill_payment_instrument.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/core/autofill_payment_instrument.h [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/core/payment_instrument.cc [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/payments/core/payment_instrument.h [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/components/test/data/payments/can_make_payment_metrics.js [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/ios/chrome/browser/payments/ios_payment_instrument.mm [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm [modify] https://crrev.com/8189d525a1814381c6c09aa15c5c8bf29a5c0669/ios/chrome/browser/ui/payments/payment_request_mediator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31885d177b085f6f815e466cddba75c36d652f6b commit 31885d177b085f6f815e466cddba75c36d652f6b Author: gogerald <gogerald@google.com> Date: Tue Sep 19 21:29:22 2017 [Payments] Implement ServiceWorkerPaymentInstrument::IsValidForModifier Bug: 762668 Change-Id: I46f083b9bc6cf304a7d47b9ba974f2e49e85111e Reviewed-on: https://chromium-review.googlesource.com/672668 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#502955} [modify] https://crrev.com/31885d177b085f6f815e466cddba75c36d652f6b/components/payments/content/service_worker_payment_instrument.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8b26061edfb289cca517f1ef03c9bda97e43d68 commit c8b26061edfb289cca517f1ef03c9bda97e43d68 Author: gogerald <gogerald@google.com> Date: Fri Nov 03 04:37:49 2017 [Payments] Add service_worker_payment_instrument_unittest Bug: 762668 Change-Id: I0f0192ddba7f9912deeb72766dd529efba484f17 Reviewed-on: https://chromium-review.googlesource.com/748768 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#513682} [modify] https://crrev.com/c8b26061edfb289cca517f1ef03c9bda97e43d68/components/payments/content/BUILD.gn [modify] https://crrev.com/c8b26061edfb289cca517f1ef03c9bda97e43d68/components/payments/content/service_worker_payment_instrument.cc [modify] https://crrev.com/c8b26061edfb289cca517f1ef03c9bda97e43d68/components/payments/content/service_worker_payment_instrument.h [add] https://crrev.com/c8b26061edfb289cca517f1ef03c9bda97e43d68/components/payments/content/service_worker_payment_instrument_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b1790db574e7d66845061f1fb830b245ef17715 commit 6b1790db574e7d66845061f1fb830b245ef17715 Author: gogerald <gogerald@google.com> Date: Wed Nov 08 21:23:43 2017 [Payments] Create an empty icon image if real icon is not available To avoid using invalid icon resource id (0) in CreateInstrumentIconView. This could happen when failed to download or parse payment handler icon. Bug: 762668 Change-Id: Ice747369e514049bf0b441e5317b30e6df007249 Reviewed-on: https://chromium-review.googlesource.com/757225 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#514942} [modify] https://crrev.com/6b1790db574e7d66845061f1fb830b245ef17715/components/payments/content/service_worker_payment_instrument.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac15d2363b90501059356f5b60ec03d84c2d5043 commit ac15d2363b90501059356f5b60ec03d84c2d5043 Author: gogerald <gogerald@google.com> Date: Wed Nov 15 01:04:19 2017 [Payments] Wire up CanMakePaymentEvent for service worker payment handler Bug: 762668 Change-Id: Ifbbeb83e02bac1933ad8b7497d0f9c95eae8e81e Reviewed-on: https://chromium-review.googlesource.com/767350 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#516536} [modify] https://crrev.com/ac15d2363b90501059356f5b60ec03d84c2d5043/components/payments/content/payment_request_state.cc [modify] https://crrev.com/ac15d2363b90501059356f5b60ec03d84c2d5043/components/payments/content/payment_request_state.h [modify] https://crrev.com/ac15d2363b90501059356f5b60ec03d84c2d5043/components/payments/content/service_worker_payment_instrument.cc [modify] https://crrev.com/ac15d2363b90501059356f5b60ec03d84c2d5043/components/payments/content/service_worker_payment_instrument.h [modify] https://crrev.com/ac15d2363b90501059356f5b60ec03d84c2d5043/components/payments/content/service_worker_payment_instrument_unittest.cc
Marking this fixed in favor of other launch bug.
Comment 1 by bugdroid1@chromium.org
, Sep 6 2017