New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762667 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-Files-Touch
Fixing-touch


Sign in to add a comment

Touching renaming text field closes soft keyboard

Project Member Reported by mcirimele@chromium.org, Sep 6 2017

Issue description

Chrome Version: 63.0.3206.0 9916.0.0 Kevin

What steps will reproduce the problem?
(1) Put device in tablet/touch mode
(2) Select a file or folder
(3) Open the overflow menu and tap "rename"
(4) Tap the text field 

What is the expected result?
The text stops being highlighted, the cursor starts blinking where the user tapped. The soft keyboard stays open.

What happens instead?
The soft keyboard closes.

Video: https://drive.google.com/open?id=0B-PpvprrWoupb3p2d2FSb2hiU3c
 
Labels: -M-63 M-65
Labels: -M-65 M-66
Labels: OS-Chrome
Status: Available (was: Untriaged)
I think this is a bug with FileTapHandler class because this happens only when the rename is started while one file is check-selected.
Owner: joelhockey@chromium.org
Cc: yamaguchi@chromium.org fukino@chromium.org
I can see the problem ;-)   (google.com/search?q=engineer+guillotine)

This bug was introduced from crosreview.com/622332.

Now I have to work out how to fix this bug but not regress the other 2 bugs:  crbug.com/755774 ,  crbug.com/756839 

yamaguchi@ and fukino@, please let me know if you have any ideas for this.
I'd recommend you to begin with reading FileTapHandler class, which is the class that I added when we introduced touch-specific UI.
My guess is, when it is in the check-select mode (at least 1 or more file has the checkbox checked), tapHandler_.hadleTouchEvents goes to the "touch to toggle select" block. It doesn't distinguish whether the tap is inside the rename text box or not.
(This is another issue caused by it; tapping causes toggle file selection.)
So my suggestion is not to do the touch-specific action in the tapHandler_.handleToucheEvents, but just let it processed by the emulated mouse click, while renaming is in progress. Some other functions uses namingController_.isRenamingInProgress() for seeing such condition.

I guess it would also resolve the issue with virtual keyboard.
In FileListSelectionController.prototype.handleTouchEvents, if tapHandler_.handleTouchEvents just refuses (=return false), then it won't hit the path introduced by change 622332.

Also, the problem should also be verified in the grid view (thubmnails) mode.
> (This is another issue caused by it; tapping causes toggle file selection.)
To clarify, this means:
""" Besides the issue that Touching renaming text field closes soft keyboard, touching the renaming text field also toggles the selection of the file, which is also considered a bug. """

Comment 8 by sashab@chromium.org, Feb 16 2018

Labels: CrOS-FilesApp-Touch
Status: Assigned (was: Available)
<files-triage>
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db634e6c248307e59c623c3633dfc4422b1ce9f2

commit db634e6c248307e59c623c3633dfc4422b1ce9f2
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Feb 16 02:55:08 2018

Revert to click handling for touch on input during rename

Bug:  762667 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iebf2bf6bc2adf62e723013602f92f3451aed8038
Reviewed-on: https://chromium-review.googlesource.com/920203
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537152}
[modify] https://crrev.com/db634e6c248307e59c623c3633dfc4422b1ce9f2/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Google Chrome	66.0.3352.0 (Official Build) dev (64-bit)
Platform	10431.0.0 (Official Build) dev-channel eve
Firmware Version	Google_Eve.9584.107.0

Sign in to add a comment