New issue
Advanced search Search tips

Issue 762643 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros chrome-sdk: Print error if download-vm fails

Project Member Reported by achuith@chromium.org, Sep 6 2017

Issue description

Not all boards produce VM images. Maybe this should be changed.

If we fail to find a VM image for a board, and --download-vm has been specified, we throw a GSNoSuchKey exception and fail to enter the sdk chroot. We should just print an error instead and continue.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ea2d0b8af06cb79388a0067daaa80fe4b6527784

commit ea2d0b8af06cb79388a0067daaa80fe4b6527784
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Wed Sep 06 23:54:34 2017

cros_chrome_sdk: Continue if VM is not found.

VM image is not generated for some boards. --download-vm now prints an
error message instead of failing.

BUG= chromium:762643 
TEST=manual

Change-Id: Ied5f873281646ada13c31774953566549b149024
Reviewed-on: https://chromium-review.googlesource.com/651886
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/ea2d0b8af06cb79388a0067daaa80fe4b6527784/cli/cros/cros_chrome_sdk.py

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment