New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762628 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640685



Sign in to add a comment

Quick view: Open button and options should be the same as in Files app

Project Member Reported by mcirimele@chromium.org, Sep 6 2017

Issue description

Chrome Version: (copy from chrome://version)

The open button in Quick view uses a different icon than the one in Files app. Let's replace the Quick view open icon with the "OPEN" we use in Files app. We should also consider adding in the same open options for the file that are available from Files app.
 
Sorry forgot to add:
63.0.3206.0 9916.0.0 Kevin

See attached screenshots.
Screenshot 2017-09-06 at 11.27.33 AM.png
2.7 MB View Download
Screenshot 2017-09-06 at 11.27.15 AM.png
2.1 MB View Download
Blocking: 640685
Labels: -M-63 M-64

Comment 3 by oka@chromium.org, Oct 3 2017

Owner: marian...@google.com
Status: Assigned (was: Untriaged)
Marianne, could you take a look?
Status: Started (was: Assigned)
Starting to look into it while the design for my intern project is being discussed
Update on the current state:

I have successfully replaced the button. There are still some issues with the drop down menu if there is more than 1 option, and some styling issues - the rest should be done.
Styling issue of the drop down menu is done, reaction to clicks on the drop down menu are still pending.
Owner: oka@chromium.org
oka@ - Per the comments, it looks like mariannet@ made some updates for this, but I don't see any CLs here. Could you check if this bug was fixed or if it's still an open issue?

Comment 8 by oka@chromium.org, Dec 6 2017

Hmm. Looks like she forgot to upload the change...

Comment 9 by oka@chromium.org, Dec 6 2017

Confirmed the issue is not fixed on ToT.

Comment 10 by oka@chromium.org, Dec 6 2017

Owner: fukino@chromium.org
Status: Assigned (was: Started)
Deferring this to fukino@ for triage. Thanks.
Labels: -M-64 M-65
Labels: -M-65 M-66
Labels: Hotlist-GoodFirstBug OS-Chrome
Owner: noel@chromium.org
Labels: CrOS-FilesApp-QuickView
<files-triage>
Labels: -CrOS-FilesApp-QuickView CrOSFilesFeature-QuickView
Labels: -M-66 M-67
Labels: -M-67
Owner: ----
Status: Available (was: Assigned)
Labels: Files-Fixit-2018

Sign in to add a comment