Need to add metrics to track popup changes |
||||||||
Issue descriptionWe are currently looking into different ways to improve popup blocking. We need to add relevant use-counters to assess the effect of our changes. At the very least, we should track the followings (from ojan@'s email): - % popups blocked (not clear if up or down is better, but we'd expect it to change) - % popups where the user clicks through to the popup anyways (we'd hope this number goes down) - time on popup landing pages (hope this number goes up).
,
Sep 6 2017
I found the following non-obsolete entries in the histograms.xml: ContentSettings.DefaultPopupsSetting: The default popups setting at profile open. toyoshim@chromium.org ContentSettings.Popups: Tracks whether the popup content blocked puzzle piece was shown in the Omnibox, and how the user interacted with it. charleszhao@chromium.org SubresourceFilter.PageLoad.BlockedPopups: Records the number of popups blocked per page load due to subresource filter logic. Recorded when a new main frame navigation commits. Note that this histogram is recorded for all pages which are activated by the subresource filter, including ones which do not trigger the stronger popup blocker. csharrison@chromium.org WindowManager.PopUpWindowCountPerLoad: The number of popup windows open when a load completes. Popup windows only have one content area (no multiple tabs) and a stripped down toolbar consisting only of a read-only address bar. kuscher@chromium.org Here are a few more that seem uninteresting for us: Extensions.PopupCreateTime Extensions.PopupLoadTime2 Omnibox.FocusToOpenTimeAnyPopupState3 Omnibox.IsPopupOpen PasswordManager.AutocompletePopupSuppressedByGeneration
,
Sep 6 2017
Assigning to csharrison@ since he already owns one.
,
Sep 6 2017
Sure, this sounds like something I can own.
,
Sep 7 2017
In email Ojan mentioned another metric which would be useful to track: "we might want to add UMA to the popup blocker to see how often users see multiple blocked popups on a page and how often users click on the first, middle, or last links"
,
Sep 7 2017
E.g. it is likely that users ignore initial, malicious popups but later might actually need to navigate to a later one that was blocked but is legitimate.
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b72e5d944e746138a0ec7e156c7065203044a974 commit b72e5d944e746138a0ec7e156c7065203044a974 Author: Charles Harrison <csharrison@chromium.org> Date: Fri Sep 08 21:17:42 2017 Introduce PopupTracker A PopupTracker is attached to any WebContents that is classified as a popup. E.g. it is handled by the popup blocker. It's purpose is to log metrics, with the end goal being to have a metric for engagement time on a popup landing page (e.g. the first non blank document). Bug: 762617 Change-Id: I198ba1fc58b8211d78fcae32f3f74148da7025cb Reviewed-on: https://chromium-review.googlesource.com/653804 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#500673} [modify] https://crrev.com/b72e5d944e746138a0ec7e156c7065203044a974/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b72e5d944e746138a0ec7e156c7065203044a974/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/b72e5d944e746138a0ec7e156c7065203044a974/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h [add] https://crrev.com/b72e5d944e746138a0ec7e156c7065203044a974/chrome/browser/ui/blocked_content/popup_tracker.cc [add] https://crrev.com/b72e5d944e746138a0ec7e156c7065203044a974/chrome/browser/ui/blocked_content/popup_tracker.h [add] https://crrev.com/b72e5d944e746138a0ec7e156c7065203044a974/chrome/browser/ui/blocked_content/popup_tracker_browsertest.cc [modify] https://crrev.com/b72e5d944e746138a0ec7e156c7065203044a974/chrome/browser/ui/browser.cc [modify] https://crrev.com/b72e5d944e746138a0ec7e156c7065203044a974/chrome/test/BUILD.gn
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3228b636420a655e7fe88f0e086bfb072be48d34 commit 3228b636420a655e7fe88f0e086bfb072be48d34 Author: Charles Harrison <csharrison@chromium.org> Date: Mon Sep 11 17:57:50 2017 Popup metrics: Log popup position at click through time This allows us to see if a user is e.g. getting a bunch of spammy popups at first and then one last "legitimate" one. Bug: 762617 Change-Id: I5ea40208930fe69b4f75c57db36170ec55029f25 Reviewed-on: https://chromium-review.googlesource.com/658287 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#500970} [modify] https://crrev.com/3228b636420a655e7fe88f0e086bfb072be48d34/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc [modify] https://crrev.com/3228b636420a655e7fe88f0e086bfb072be48d34/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/3228b636420a655e7fe88f0e086bfb072be48d34/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h [modify] https://crrev.com/3228b636420a655e7fe88f0e086bfb072be48d34/tools/metrics/histograms/enums.xml [modify] https://crrev.com/3228b636420a655e7fe88f0e086bfb072be48d34/tools/metrics/histograms/histograms.xml
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afff8634b842c715ebf986af84ab56e5e1bbc3b3 commit afff8634b842c715ebf986af84ab56e5e1bbc3b3 Author: Charles Harrison <csharrison@chromium.org> Date: Mon Sep 11 20:59:31 2017 Popup metrics: Add initiated/blocked/clicked through metric This will allow us to calculate: - % of popups blocked - % of popups clicked through Bug: 762617 Change-Id: Iaa850d03adb75e04b629b2d8623b0680b7dd095d Reviewed-on: https://chromium-review.googlesource.com/658225 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#501038} [modify] https://crrev.com/afff8634b842c715ebf986af84ab56e5e1bbc3b3/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc [modify] https://crrev.com/afff8634b842c715ebf986af84ab56e5e1bbc3b3/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/afff8634b842c715ebf986af84ab56e5e1bbc3b3/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h [modify] https://crrev.com/afff8634b842c715ebf986af84ab56e5e1bbc3b3/tools/metrics/histograms/enums.xml [modify] https://crrev.com/afff8634b842c715ebf986af84ab56e5e1bbc3b3/tools/metrics/histograms/histograms.xml
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450 commit b614fd5ed5c99ea5daa788fb00ac5919ac0eb450 Author: Charles Harrison <csharrison@chromium.org> Date: Mon Sep 11 21:35:59 2017 Popup metrics: Add metrics for popup engagement This patch adds visibility tracking to the PopupTracker, and it logs the duration a popup is visible from its first navigation commit until that document is navigated away from (or the web contents is destroyed). Bug: 762617 Change-Id: I538712c4f31e8335521da1a283852ef8db3b138d Reviewed-on: https://chromium-review.googlesource.com/656198 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#501047} [modify] https://crrev.com/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450/chrome/browser/ui/blocked_content/popup_tracker.cc [modify] https://crrev.com/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450/chrome/browser/ui/blocked_content/popup_tracker.h [modify] https://crrev.com/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450/chrome/browser/ui/blocked_content/popup_tracker_browsertest.cc [add] https://crrev.com/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450/chrome/browser/ui/blocked_content/scoped_visibility_tracker.cc [add] https://crrev.com/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450/chrome/browser/ui/blocked_content/scoped_visibility_tracker.h [add] https://crrev.com/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450/chrome/browser/ui/blocked_content/scoped_visibility_tracker_unittest.cc [modify] https://crrev.com/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450/chrome/test/BUILD.gn [modify] https://crrev.com/b614fd5ed5c99ea5daa788fb00ac5919ac0eb450/tools/metrics/histograms/histograms.xml
,
Sep 11 2017
I think that's everything that was mentioned, let's re-open if we think of any more to add.
,
Sep 12 2017
,
Sep 12 2017
Avi, looks like mustaq and the user gesture project require these metrics in M62, to compare to their incoming M63 rollout. I'm about to head off for vacation, would you be willing to merge these to M62?
,
Sep 12 2017
Let's ask. If it's approved I'll handle the merge. Please make the case for the merge.
,
Sep 12 2017
Can you please mark all impacting OS's?
,
Sep 12 2017
,
Sep 12 2017
These changes adds new UMA metrics, without any functional changes in Chrome. We want to start tracking popup blocking metrics in M62 to assess our planned changes in M63 around simple user gestures (Issue 696617).
,
Sep 13 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50566ddebb8ed3e5de9c0f150767276858486271 commit 50566ddebb8ed3e5de9c0f150767276858486271 Author: Avi Drissman <avi@chromium.org> Date: Wed Sep 13 18:01:55 2017 Introduce PopupTracker A PopupTracker is attached to any WebContents that is classified as a popup. E.g. it is handled by the popup blocker. It's purpose is to log metrics, with the end goal being to have a metric for engagement time on a popup landing page (e.g. the first non blank document). TBR=csharrison@chromium.org Bug: 762617 Change-Id: I198ba1fc58b8211d78fcae32f3f74148da7025cb Reviewed-on: https://chromium-review.googlesource.com/653804 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500673}(cherry picked from commit b72e5d944e746138a0ec7e156c7065203044a974) Reviewed-on: https://chromium-review.googlesource.com/665440 Cr-Commit-Position: refs/branch-heads/3202@{#205} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/50566ddebb8ed3e5de9c0f150767276858486271/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/50566ddebb8ed3e5de9c0f150767276858486271/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/50566ddebb8ed3e5de9c0f150767276858486271/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h [add] https://crrev.com/50566ddebb8ed3e5de9c0f150767276858486271/chrome/browser/ui/blocked_content/popup_tracker.cc [add] https://crrev.com/50566ddebb8ed3e5de9c0f150767276858486271/chrome/browser/ui/blocked_content/popup_tracker.h [add] https://crrev.com/50566ddebb8ed3e5de9c0f150767276858486271/chrome/browser/ui/blocked_content/popup_tracker_browsertest.cc [modify] https://crrev.com/50566ddebb8ed3e5de9c0f150767276858486271/chrome/browser/ui/browser.cc [modify] https://crrev.com/50566ddebb8ed3e5de9c0f150767276858486271/chrome/test/BUILD.gn
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20765465edec5af7a57abfe2b6e2e69f13e8e2ee commit 20765465edec5af7a57abfe2b6e2e69f13e8e2ee Author: Avi Drissman <avi@chromium.org> Date: Wed Sep 13 20:42:13 2017 Popup metrics: Log popup position at click through time This allows us to see if a user is e.g. getting a bunch of spammy popups at first and then one last "legitimate" one. TBR=csharrison@chromium.org Bug: 762617 Change-Id: I5ea40208930fe69b4f75c57db36170ec55029f25 Reviewed-on: https://chromium-review.googlesource.com/658287 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500970}(cherry picked from commit 3228b636420a655e7fe88f0e086bfb072be48d34) Reviewed-on: https://chromium-review.googlesource.com/665580 Cr-Commit-Position: refs/branch-heads/3202@{#209} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/20765465edec5af7a57abfe2b6e2e69f13e8e2ee/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc [modify] https://crrev.com/20765465edec5af7a57abfe2b6e2e69f13e8e2ee/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/20765465edec5af7a57abfe2b6e2e69f13e8e2ee/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h [modify] https://crrev.com/20765465edec5af7a57abfe2b6e2e69f13e8e2ee/tools/metrics/histograms/enums.xml [modify] https://crrev.com/20765465edec5af7a57abfe2b6e2e69f13e8e2ee/tools/metrics/histograms/histograms.xml
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a82b4ad169b92bac6a1a58a2a2887f0ef49e28d3 commit a82b4ad169b92bac6a1a58a2a2887f0ef49e28d3 Author: Charles Harrison <csharrison@chromium.org> Date: Thu Sep 14 13:56:41 2017 Popup metrics: Add initiated/blocked/clicked through metric This will allow us to calculate: - % of popups blocked - % of popups clicked through Bug: 762617 Change-Id: Iaa850d03adb75e04b629b2d8623b0680b7dd095d Reviewed-on: https://chromium-review.googlesource.com/658225 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501038}(cherry picked from commit afff8634b842c715ebf986af84ab56e5e1bbc3b3) Reviewed-on: https://chromium-review.googlesource.com/667057 Cr-Commit-Position: refs/branch-heads/3202@{#218} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/a82b4ad169b92bac6a1a58a2a2887f0ef49e28d3/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc [modify] https://crrev.com/a82b4ad169b92bac6a1a58a2a2887f0ef49e28d3/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/a82b4ad169b92bac6a1a58a2a2887f0ef49e28d3/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h [modify] https://crrev.com/a82b4ad169b92bac6a1a58a2a2887f0ef49e28d3/tools/metrics/histograms/enums.xml [modify] https://crrev.com/a82b4ad169b92bac6a1a58a2a2887f0ef49e28d3/tools/metrics/histograms/histograms.xml
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f67661f96fee332d58fcf4218dec6b31b84e7924 commit f67661f96fee332d58fcf4218dec6b31b84e7924 Author: Charles Harrison <csharrison@chromium.org> Date: Thu Sep 14 17:44:22 2017 Popup metrics: Add metrics for popup engagement This patch adds visibility tracking to the PopupTracker, and it logs the duration a popup is visible from its first navigation commit until that document is navigated away from (or the web contents is destroyed). Bug: 762617 Change-Id: I538712c4f31e8335521da1a283852ef8db3b138d Reviewed-on: https://chromium-review.googlesource.com/656198 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501047}(cherry picked from commit b614fd5ed5c99ea5daa788fb00ac5919ac0eb450) Reviewed-on: https://chromium-review.googlesource.com/667541 Cr-Commit-Position: refs/branch-heads/3202@{#226} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/f67661f96fee332d58fcf4218dec6b31b84e7924/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/f67661f96fee332d58fcf4218dec6b31b84e7924/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/f67661f96fee332d58fcf4218dec6b31b84e7924/chrome/browser/ui/blocked_content/popup_tracker.cc [modify] https://crrev.com/f67661f96fee332d58fcf4218dec6b31b84e7924/chrome/browser/ui/blocked_content/popup_tracker.h [modify] https://crrev.com/f67661f96fee332d58fcf4218dec6b31b84e7924/chrome/browser/ui/blocked_content/popup_tracker_browsertest.cc [add] https://crrev.com/f67661f96fee332d58fcf4218dec6b31b84e7924/chrome/browser/ui/blocked_content/scoped_visibility_tracker.cc [add] https://crrev.com/f67661f96fee332d58fcf4218dec6b31b84e7924/chrome/browser/ui/blocked_content/scoped_visibility_tracker.h [add] https://crrev.com/f67661f96fee332d58fcf4218dec6b31b84e7924/chrome/browser/ui/blocked_content/scoped_visibility_tracker_unittest.cc [modify] https://crrev.com/f67661f96fee332d58fcf4218dec6b31b84e7924/chrome/test/BUILD.gn [modify] https://crrev.com/f67661f96fee332d58fcf4218dec6b31b84e7924/tools/metrics/histograms/histograms.xml
,
Sep 14 2017
OK, this is merged to M62.
,
Sep 14 2017
Thanks Avi for taking care of this. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by csharrison@chromium.org
, Sep 6 2017