New issue
Advanced search Search tips

Issue 762616 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-XR



Sign in to add a comment

VR: Updating VR Services doesn't fix VR until Chrome is relaunched.

Project Member Reported by mthiesse@chromium.org, Sep 6 2017

Issue description

It looks like updating VR Services no longer causes Chrome to relaunch automatically, so even after updating VR Services WebVR won't work until the user manually restarts the browser.
 
Labels: -M-63 M-62
Labels: -Type-Bug Type-Bug-Regression
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5263c66199109b6f315ae0864aeed6f09a048d27

commit 5263c66199109b6f315ae0864aeed6f09a048d27
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Wed Sep 06 23:37:31 2017

VR: Restart chrome when user updates VR Services through prompt.

Triggers a restart of Chrome when the user returns to chrome after
following the prompt to update VR Services, and VR Service version has
changed.

Bug:  762616 
Change-Id: Ib6028bf5e56bd8e77218b163066ac3d8c45e1e03
Reviewed-on: https://chromium-review.googlesource.com/653798
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500113}
[modify] https://crrev.com/5263c66199109b6f315ae0864aeed6f09a048d27/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/5263c66199109b6f315ae0864aeed6f09a048d27/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Labels: Merge-Request-62
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 8 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 12 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 12 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cabe2c90dab082685df21fa30bbf41e213bb2dec

commit cabe2c90dab082685df21fa30bbf41e213bb2dec
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Tue Sep 12 19:49:28 2017

VR: Restart chrome when user updates VR Services through prompt.

Triggers a restart of Chrome when the user returns to chrome after
following the prompt to update VR Services, and VR Service version has
changed.

Bug:  762616 
Change-Id: Ib6028bf5e56bd8e77218b163066ac3d8c45e1e03
Reviewed-on: https://chromium-review.googlesource.com/653798
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500113}(cherry picked from commit 5263c66199109b6f315ae0864aeed6f09a048d27)
Reviewed-on: https://chromium-review.googlesource.com/663634
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#179}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/cabe2c90dab082685df21fa30bbf41e213bb2dec/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/cabe2c90dab082685df21fa30bbf41e213bb2dec/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified on Pixel XL 62.0.3202.38
Components: Internals>XR

Sign in to add a comment