Issue metadata
Sign in to add a comment
|
Chrome VR - Microphone in use indicator way off to the left of the content window |
||||||||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3202.8 OS: Android N VRCore: 1.8.163477258 What steps will reproduce the problem? (1) Go to http://permission.site/ in 2D mode (2) select Microphone and grant permissions (3) Enter Chrome VR What is the expected result? Microphone in use indicator shown above content area. What happens instead? Microphone in use indicator is shown far off to the left. It's hard to see. See screenshot attached.
,
Sep 6 2017
,
Sep 7 2017
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/741fa2ff2e13bc86d641434bcf7e3919b27430fb commit 741fa2ff2e13bc86d641434bcf7e3919b27430fb Author: Ian Vollick <vollick@chromium.org> Date: Thu Sep 07 03:26:47 2017 [vr] Ensure that requires_layout is set for indictors Now that we're using requires_layout() to flag elements for requiring layout, we must be sure to actually set it. Bug: 762604 Change-Id: Iad71b42f5496311b6d95a8ec591315f295165843 Reviewed-on: https://chromium-review.googlesource.com/654181 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#500208} [modify] https://crrev.com/741fa2ff2e13bc86d641434bcf7e3919b27430fb/chrome/browser/vr/test/ui_scene_manager_test.cc [modify] https://crrev.com/741fa2ff2e13bc86d641434bcf7e3919b27430fb/chrome/browser/vr/test/ui_scene_manager_test.h [modify] https://crrev.com/741fa2ff2e13bc86d641434bcf7e3919b27430fb/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/741fa2ff2e13bc86d641434bcf7e3919b27430fb/chrome/browser/vr/ui_scene_manager_unittest.cc
,
Sep 7 2017
,
Sep 7 2017
,
Sep 8 2017
,
Sep 8 2017
Verified in 63.0.3210.0
,
Sep 9 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da518c2e397326fa3928a5c086c056a6910ba80d commit da518c2e397326fa3928a5c086c056a6910ba80d Author: Ian Vollick <vollick@chromium.org> Date: Sat Sep 09 21:07:10 2017 [vr] Ensure that requires_layout is set for indictors Now that we're using requires_layout() to flag elements for requiring layout, we must be sure to actually set it. TBR=vollick@chromium.org (cherry picked from commit 741fa2ff2e13bc86d641434bcf7e3919b27430fb) Bug: 762604 Change-Id: Iad71b42f5496311b6d95a8ec591315f295165843 Reviewed-on: https://chromium-review.googlesource.com/654181 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500208} Reviewed-on: https://chromium-review.googlesource.com/658503 Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#108} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/da518c2e397326fa3928a5c086c056a6910ba80d/chrome/browser/vr/test/ui_scene_manager_test.cc [modify] https://crrev.com/da518c2e397326fa3928a5c086c056a6910ba80d/chrome/browser/vr/test/ui_scene_manager_test.h [modify] https://crrev.com/da518c2e397326fa3928a5c086c056a6910ba80d/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/da518c2e397326fa3928a5c086c056a6910ba80d/chrome/browser/vr/ui_scene_manager_unittest.cc
,
Sep 9 2017
,
Sep 15 2017
|
|||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||
Comment 1 by dbbrooks@chromium.org
, Sep 6 20171017 KB
1017 KB View Download