New issue
Advanced search Search tips

Issue 762603 link

Starred by 2 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Sep 2017
Cc:
tbuck...@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Exit mode when activating stylus tools menu

Project Member Reported by tbuck...@chromium.org, Sep 6 2017 
Chrome Version: 61.0.3163.70
OS Version: 9765.48.0

What steps will reproduce the problem?
1) Activate ChromeVox
2) Use Alt+Shift+P to focus the stylus tools menu
3) Use tab / enter to activate a stylus mode (eg. laser pointer)
4) Use Alt+Shift+P to focus the stylus tools menu again

Expected: mode is exited and stylus tools menu opens (or menu button is focused and state is announced, and pressing enter/space exits the mode)
Actual: menu is opened despite mode still being active


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 9765.48.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.70 Safari/537.36
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0e9500011d99dfd43654e5217253c3107e3f4ec

commit c0e9500011d99dfd43654e5217253c3107e3f4ec
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Sep 18 19:17:07 2017

ash: Current stylus tool is exited when palette bubble is opened.

This bug happens when someone uses the accelerator shortcut (alt shift P) to open the palette bubble. Before, to deactivate the current tool, users have tap the palette tool tray, but this step is bypassed the accelerator is used. So we deactivate the active tool if there is one when the bubble is opened.

Test: ash_unittests PaletteTrayTestWithInternalStylus.ToolDeactivatesWhenOpeningBubble
Bug:  762603 
Change-Id: I985cf174587bdebe60eedc621617ba5c32f33a3e
Reviewed-on: https://chromium-review.googlesource.com/667860
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502634}
[modify] https://crrev.com/c0e9500011d99dfd43654e5217253c3107e3f4ec/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/c0e9500011d99dfd43654e5217253c3107e3f4ec/ash/system/palette/palette_tray.h
[modify] https://crrev.com/c0e9500011d99dfd43654e5217253c3107e3f4ec/ash/system/palette/palette_tray_unittest.cc

Comment 2 by sammiequon@chromium.org, Sep 20 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment