New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762602 link

Starred by 1 user
Status: Fixed
Owner:
█ kbr@chromium.org
OOO until 2019-01-24
Closed: Sep 2017
Cc:
█ phajdan.jr@chromium.org
█ phajdan@google.com
dpranke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 743212


Sign in to add a comment

Tests for trybot configurations don't work for ANGLE

Project Member Reported by kbr@chromium.org, Sep 6 2017 
In  Issue 743212  the bot "Linux ChromiumOS Builder" was removed from the chromium.gpu.fyi waterfall. This broke ANGLE's CQ because there was still a reference to this bot from https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/trybots.py . See  Issue 762377 .

There used to be tests in the tools/build workspace which would ensure that all the bots in trybots.py existed on the waterfalls which they mirrored. Have these tests been lost?

Comment 1 by dpranke@chromium.org, Sep 6 2017 

I'm not actually sure we do have a check that every trybot's references correspond to actual entries in the masters. I would've thought we did, but I'm not positive (and haven't checked yet).

Whoops :(.

Comment 2 by kbr@chromium.org, Sep 6 2017 

I'm pretty sure such a test used to exist; I remember breaking it a bunch of times while working on the GPU trybots a while ago.

The issue here is that the trybot in trybots.py was referencing a waterfall bot that didn't exist in chromium_gpu_fyi.py. That should be easy to catch -- no cross-checks with the masters are necessary.

Comment 3 by dpranke@chromium.org, Sep 6 2017

Status: Available (was: Untriaged)
Summary: Tests for trybot configurations don't work for ANGLE (was: Tests for trybot configurations seem to have been lost)
Looks like the test exists (tests/masters_recipes_test.py) but isn't configured to look at bots on tryserver.chromium.angle or on master.chromium.gpu.fyi.

Changing the subject title from "Tests for trybot configurations seem to have been lost" to "Tests for trybot configurations don't work for ANGLE".

Comment 4 by phajdan.jr@chromium.org, Sep 14 2017

Cc: phajdan@google.com
Labels: -Restrict-View-Google
tests/masters_recipes_test.py mostly checks for match between buildbot master configuration and recipe configuration.

While it does not currently check FYI or ANGLE masters, feel free to add them.

Note that we could also use a recipe-side test to verify all trybots.py entries (now that builder-specific expectations have been removed), just without emitting an expectation file itself.

Comment 5 by kbr@chromium.org, Sep 20 2017

Owner: kbr@chromium.org
Status: Started (was: Available)
https://chromium-review.googlesource.com/674041 up for review.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/489ef71c38b092b8bfe7d7ba2864e99e852ec181

commit 489ef71c38b092b8bfe7d7ba2864e99e852ec181
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Sep 20 23:32:58 2017

Verify tryserver.chromium.angle in masters_recipes_test.

BUG= 762602 

Change-Id: I4e798358a465af889b5999e5a6c7096f816a43af
Reviewed-on: https://chromium-review.googlesource.com/674041
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/489ef71c38b092b8bfe7d7ba2864e99e852ec181/tests/masters_recipes_test.py

Comment 7 by kbr@chromium.org, Sep 25 2017

Status: Fixed (was: Started)
tryserver.chromium.angle is now tested. We can't add tests for chromium.gpu.fyi asserting that all the configurations are covered by trybots, because that waterfall deliberately contains a lot of one-off hardware. Closing as fixed.
►

Sign in to add a comment