Move animation logic from OmniboxPopupViewIOS::UpdatePopupAppearance to popup coordinator |
||
Issue descriptionCurrently in OmniboxPopupViewIOS::UpdatePopupAppearance() there's logic to decide wether the popup needs to be animated. This needs to be done in coordinator layer instead.
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e685b2dfc234cb39d713b16204d0f85375f229b9 commit e685b2dfc234cb39d713b16204d0f85375f229b9 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Dec 14 14:16:58 2017 Box OmniboxPopup to a coordinator This CL creates a OmniboxPopupCoordinator and boxes the ViewController, mediator and presenter inside. For now the coordinator is still owned and activated by the OmniboxPopupViewIOS. In future CL the coordinator will own the OmniboxPopupViewIOS. Bug: 762597 ,788640 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ief006d3c8e8668824111fd513d249dc90be51d1e Reviewed-on: https://chromium-review.googlesource.com/824664 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524062} [modify] https://crrev.com/e685b2dfc234cb39d713b16204d0f85375f229b9/ios/chrome/browser/ui/omnibox/BUILD.gn [modify] https://crrev.com/e685b2dfc234cb39d713b16204d0f85375f229b9/ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.h [modify] https://crrev.com/e685b2dfc234cb39d713b16204d0f85375f229b9/ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.mm [add] https://crrev.com/e685b2dfc234cb39d713b16204d0f85375f229b9/ios/chrome/browser/ui/omnibox/popup/BUILD.gn [add] https://crrev.com/e685b2dfc234cb39d713b16204d0f85375f229b9/ios/chrome/browser/ui/omnibox/popup/OWNERS [add] https://crrev.com/e685b2dfc234cb39d713b16204d0f85375f229b9/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.h [add] https://crrev.com/e685b2dfc234cb39d713b16204d0f85375f229b9/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm
,
Dec 14 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by gambard@chromium.org
, Dec 13 2017Owner: gambard@chromium.org
Status: Started (was: Assigned)