org/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.class Call requires API level 17 (current min is 16): `android.widget.ScrollView#getPaddingEnd`: NewApi [warning] |
|||||
Issue descriptionorg/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.class Call requires API level 17 (current min is 16): `android.widget.ScrollView#getPaddingEnd`: NewApi [warning] org/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.class Call requires API level 17 (current min is 16): `android.widget.ScrollView#getPaddingStart`: NewApi [warning] org/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.class Call requires API level 17 (current min is 16): `android.widget.ScrollView#setPaddingRelative`: NewApi [warning]
,
Sep 6 2017
If this is on 62, we should probably get this fixed and landed on there to prevent crashes on older versions. Marking as RBS proactively, but feel free to remove if overzealous.
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6977419a4fb2aab5b56efeaf1e74714a508ec5a3 commit 6977419a4fb2aab5b56efeaf1e74714a508ec5a3 Author: Troy Hildebrandt <thildebr@chromium.org> Date: Thu Sep 07 15:52:09 2017 [Home] Fix reliance on API 17+ for Incognito NTP padding fix. Uses ApiCompatibilityUtils getPaddingStart/End to more safely retrieve these values. Bug: 762591 Change-Id: Ieaabf06ec193d01b57fce6bc243f2de2a2aafb8c Reviewed-on: https://chromium-review.googlesource.com/653838 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#500309} [modify] https://crrev.com/6977419a4fb2aab5b56efeaf1e74714a508ec5a3/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.java
,
Sep 8 2017
Requesting merge for CL from #3. Fixes a potential issue that affects early JB users when using Chrome Home and viewing the Incognito NTP page due to reliance on API 17+.
,
Sep 9 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d378c50b5e00c06c0e05d2926cd5823ec8eff85a commit d378c50b5e00c06c0e05d2926cd5823ec8eff85a Author: Matthew Jones <mdjones@chromium.org> Date: Tue Sep 12 14:48:37 2017 [Home] Fix reliance on API 17+ for Incognito NTP padding fix. Uses ApiCompatibilityUtils getPaddingStart/End to more safely retrieve these values. TBR=thildebr@chromium.org (cherry picked from commit 6977419a4fb2aab5b56efeaf1e74714a508ec5a3) Bug: 762591 Change-Id: Ieaabf06ec193d01b57fce6bc243f2de2a2aafb8c Reviewed-on: https://chromium-review.googlesource.com/653838 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500309} Reviewed-on: https://chromium-review.googlesource.com/663519 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#165} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/d378c50b5e00c06c0e05d2926cd5823ec8eff85a/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.java |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by wnwen@chromium.org
, Sep 6 2017