New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762590 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

[Contextual Suggestions] Missing context menu for the contextual suggestions carousel

Project Member Reported by galinap@google.com, Sep 6 2017

Issue description

Currently we have context menu for any types of suggestions apart from Contextual suggestions. It would be nice to add this feature the contextual suggestions too.

We probably want the following items to be present in the context menu:

- open in this tab
- open in a new tab
- download this suggestion

We don't want to be able to remove contextual suggestions as they are temporary anyway.
 

Comment 1 by galinap@google.com, Sep 6 2017

Labels: -OS-Android OS-Chrome

Comment 2 by galinap@google.com, Sep 6 2017

Labels: -OS-Chrome OS-Android

Comment 3 by galinap@google.com, Sep 7 2017

Components: UI>Browser>NewTabPage
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8aa41c22efab6ca1dcc68216a7617ddb2b14988

commit a8aa41c22efab6ca1dcc68216a7617ddb2b14988
Author: galinap <galinap@google.com>
Date: Fri Sep 08 21:39:56 2017

[Contextual Suggestions] Adding context menu

This CL adds context menu to contextual suggestions. The context menu
presents the following options:
- open in new tab
- open in incognito tab
- download page

Bug:  762590 
Change-Id: I6320c24faf0058d84dd0255a842c8980d816eb2d
Reviewed-on: https://chromium-review.googlesource.com/653278
Commit-Queue: Galia Peycheva <galinap@google.com>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500699}
[modify] https://crrev.com/a8aa41c22efab6ca1dcc68216a7617ddb2b14988/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java
[modify] https://crrev.com/a8aa41c22efab6ca1dcc68216a7617ddb2b14988/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsCardViewHolder.java
[modify] https://crrev.com/a8aa41c22efab6ca1dcc68216a7617ddb2b14988/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
[modify] https://crrev.com/a8aa41c22efab6ca1dcc68216a7617ddb2b14988/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsCarousel.java
[modify] https://crrev.com/a8aa41c22efab6ca1dcc68216a7617ddb2b14988/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsCarouselAdapter.java

Comment 5 by galinap@google.com, Sep 11 2017

Status: Fixed (was: Started)

Sign in to add a comment