Please reconsider landing a P1 fix for M63. Unless you know for sure that the android API was available for API level 16, or no users on API level 16 will hit this code path, it will result in many crashes.

We are only targeting Android K and newer. This code should never be executed on devices with API level 16 or lower.

Thanks for the clarification!

Setting that as not time critical since we should never hit that code with an API older than 17.

What are the next steps? Do we need to change the way we use this API or suppress the warning?

Please update the comment here to confirm, preferably with a reason, why you are sure the code is not run on K or lower: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java?q=vrshellimpl&sq=package:chromium&l=320

Thanks!

We can also check for the API level (e.g. like here https://cs.chromium.org/chromium/src/ui/android/java/src/org/chromium/ui/base/DeviceFormFactor.java?rcl=dd64a192d8b8a180fb40f389f4ecf8680467e968&l=62) and use default values here https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java?rcl=02ed3cc1d6da1dc9263ad44f9c1bc662044d78c9&l=328. The default values should never be used. However, it would give us a backup that we won't crash in case we still hit this code path.

That would be best, thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7e4fc0f8be6dc90425927d054ab9a246282f507

commit a7e4fc0f8be6dc90425927d054ab9a246282f507
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Mar 01 01:44:00 2018

[vr] Make sure Display.getRealMetrics() is only used on API Level 17+

Bug:  762588 
Change-Id: I73723544788847a2209155eec756c7573dfe7b1d
Reviewed-on: https://chromium-review.googlesource.com/788891
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539974}
[modify] https://crrev.com/a7e4fc0f8be6dc90425927d054ab9a246282f507/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java