New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762585 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR



Sign in to add a comment

Chrome VR - Some heading links can't be clicked on Tumblr

Project Member Reported by dbbrooks@chromium.org, Sep 6 2017

Issue description

Chrome Version: 62.0.3202.8
OS: Android N
VRCore: 1.8.163477258

What steps will reproduce the problem?
(1) go to tumblr.com/explore/trending
(2) enter Chrome VR
(3) Select Photos heading (or GIFs, Quotes, Links)

What is the expected result? Navigate to those links

What happens instead? Clicking doesn't register, navigation to the links doesn't occur. 

Note that clicking on the first three links works. (Trending, Staff Picks, or Text)

Also, this does not occur on M61 61.0.3163.79

 
Screenshot_20170906-094030.png
421 KB View Download
Labels: -Pri-2 ReleaseBlock-Stable Pri-1
Owner: vollick@chromium.org
Status: Available (was: Untriaged)
Not present in M61 thankfully. There's a region of the screen that can't be clicked top-center. I'm going to assume some UI element is swallowing input when it shouldn't be.
screenshot.png
762 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ecad9bc91dbd2284e6ec0afab22f1b1186cae36

commit 3ecad9bc91dbd2284e6ec0afab22f1b1186cae36
Author: Ian Vollick <vollick@chromium.org>
Date: Thu Sep 07 02:44:48 2017

[vr] The indicator layout should not be hit testable

This produces incorrect hit testing results over the top portion of
the content quad.

Bug:  762585 
Test: UiSceneManagerTest.HitTestableElements
Change-Id: If3f929bdc70493f169ceeb1ad591b3cc1b8122c9
Reviewed-on: https://chromium-review.googlesource.com/653739
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500196}
[modify] https://crrev.com/3ecad9bc91dbd2284e6ec0afab22f1b1186cae36/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/3ecad9bc91dbd2284e6ec0afab22f1b1186cae36/chrome/browser/vr/ui_scene_manager_unittest.cc
[modify] https://crrev.com/3ecad9bc91dbd2284e6ec0afab22f1b1186cae36/device/BUILD.gn

Labels: Merge-Request-62
Labels: -Merge-Request-62
Labels: Merge-Request-62
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 9 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 9 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ca296a9552775d66402c7b84a338b45d1adeecb

commit 8ca296a9552775d66402c7b84a338b45d1adeecb
Author: Ian Vollick <vollick@chromium.org>
Date: Sat Sep 09 21:10:05 2017

[vr] The indicator layout should not be hit testable

This produces incorrect hit testing results over the top portion of
the content quad.

TBR=vollick@chromium.org

(cherry picked from commit 3ecad9bc91dbd2284e6ec0afab22f1b1186cae36)

Bug:  762585 
Test: UiSceneManagerTest.HitTestableElements
Change-Id: If3f929bdc70493f169ceeb1ad591b3cc1b8122c9
Reviewed-on: https://chromium-review.googlesource.com/653739
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500196}
Reviewed-on: https://chromium-review.googlesource.com/659058
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#109}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/8ca296a9552775d66402c7b84a338b45d1adeecb/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/8ca296a9552775d66402c7b84a338b45d1adeecb/chrome/browser/vr/ui_scene_manager_unittest.cc
[modify] https://crrev.com/8ca296a9552775d66402c7b84a338b45d1adeecb/device/BUILD.gn

Status: Fixed (was: Available)
Status: Verified (was: Fixed)
verified in 63.0.3214.0
Components: Internals>XR

Sign in to add a comment