Do you mean #if !defined(OS_IOS)?

These are to replace ENABLE_CAPTIVE_PORTAL_INTERSTITIAL. SSLErrorAssistant code was behind ENABLE_CAPTIVE_PORTAL_INTERSTITIAL flag because it only handled captive portals. But now we enable it on all platforms except for IOS since it's doing more than captive portal related things.

Yeah, sorry, I meant !defined. e.g. https://cs.chromium.org/chromium/src/chrome/browser/ssl/ssl_error_handler.cc?q=ssl_error_handler&sq=package:chromium&l=287

I still don't understand why we need those? Isn't that whole file not used on iOS?

I don't see it being specifically excluded for iOS. It's part of the "browser" library. Is that not used in iOS builds? (I don't know much about iOS builds)

If so, yes we can get rid of them.

I might be totally confused but I thought nothing in chrome/browser is used on iOS because it all has //content dependencies, which aren't allowed on iOS. +eugenebut to confirm

iOS does not use any code from //chrome. iOS uses //ios/chrome.

I'll take this one. I was doing something similar for captive portals too.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac3e881ccf55479e3acc13ebb8a62eb2cfe17a2c

commit ac3e881ccf55479e3acc13ebb8a62eb2cfe17a2c
Author: Mustafa Acer <meacer@chromium.org>
Date: Mon Sep 11 20:31:01 2017

Remove extra OS_IOS statements from SSL error handling

iOS code doesn't depend on chrome/browser so these checks are not necessary.

Bug:  762584 
Change-Id: If4dd9fa9d08f43e1d76a9d14bc829bc30730d4ab
Reviewed-on: https://chromium-review.googlesource.com/660412
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501023}
[modify] https://crrev.com/ac3e881ccf55479e3acc13ebb8a62eb2cfe17a2c/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/ac3e881ccf55479e3acc13ebb8a62eb2cfe17a2c/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/ac3e881ccf55479e3acc13ebb8a62eb2cfe17a2c/chrome/browser/ssl/ssl_error_handler_unittest.cc