Implement incognito in iOS clean.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186 commit c4f2ff0b7c865eeddad61e56ea0d30d635f7e186 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 11 14:57:38 2017 [ios clean] Add TabGridContainer This CL adds a TabGridContainer, a coordinator and its ViewController. This container contains only one TabGrid for now. In the future it will contain two TabGrids, one for each mode (normal/incognito). This CL does not add any functionality to the current code, it only splits the TabGrid in two. Bug: 762578 Change-Id: Ic5b851b80c02f3ac2fa3f2ea006f687eebf8317c Reviewed-on: https://chromium-review.googlesource.com/654660 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#500916} [modify] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/actions/BUILD.gn [delete] https://crrev.com/63a9dfca367d424330cca8e6967a760205f8e5c4/ios/clean/chrome/browser/ui/actions/settings_actions.h [modify] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/root/root_coordinator.mm [modify] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/BUILD.gn [add] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_container_coordinator.h [add] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_container_coordinator.mm [add] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_container_coordinator_unittest.mm [add] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_container_view_controller.h [add] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_container_view_controller.mm [modify] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm [modify] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.h [modify] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.mm [add] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar_commands.h [modify] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.h [modify] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/c4f2ff0b7c865eeddad61e56ea0d30d635f7e186/ios/clean/chrome/browser/ui/tab_grid/ui_button+cr_tab_grid.mm [delete] https://crrev.com/63a9dfca367d424330cca8e6967a760205f8e5c4/ios/clean/chrome/browser/ui/tab_grid/ui_stack_view+cr_tab_grid.h [delete] https://crrev.com/63a9dfca367d424330cca8e6967a760205f8e5c4/ios/clean/chrome/browser/ui/tab_grid/ui_stack_view+cr_tab_grid.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3c1849aa19097b4690c7b4be93c875da0e3acba commit f3c1849aa19097b4690c7b4be93c875da0e3acba Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 11 16:21:51 2017 [ios clean] Add incognito TabGrid This CL adds a new TabGrid containing the incognito tabs. It also adds the Incognito coordinator to allow the creation of NTP in incognito. Bug: 762578 Change-Id: I7cfca54e5e816661cf365dd5f7daa57b90706949 Reviewed-on: https://chromium-review.googlesource.com/655303 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#500936} [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/commands/BUILD.gn [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/commands/ntp_commands.h [add] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/commands/tab_grid_toolbar_commands.h [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/ntp/ntp_consumer.h [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/ntp/ntp_coordinator.mm [add] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/ntp/ntp_incognito_coordinator.h [add] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/ntp/ntp_incognito_coordinator.mm [add] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/ntp/ntp_incognito_coordinator_unittest.mm [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/ntp/ntp_mediator.h [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/ntp/ntp_mediator.mm [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/ntp/ntp_view_controller.h [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/ntp/ntp_view_controller.mm [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/tab_grid/tab_grid_container_coordinator.mm [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/tab_grid/tab_grid_container_view_controller.h [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/tab_grid/tab_grid_container_view_controller.mm [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.h [modify] https://crrev.com/f3c1849aa19097b4690c7b4be93c875da0e3acba/ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfbdcf9f687f82f584b48a3fa961b090c5ec3270 commit cfbdcf9f687f82f584b48a3fa961b090c5ec3270 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 14 15:40:53 2017 [ios clean] Add incognito style This CL adds the incognito style to the toolbar, using configuration objects. Bug: 762578 Change-Id: I09e598a99b20cb5e4c08e0d56c4ef0a0b1847790 Reviewed-on: https://chromium-review.googlesource.com/657978 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#501959} [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/tab/BUILD.gn [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/tab/tab_container_view_controller.h [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/tab_grid/tab_grid_container_coordinator.mm [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/BUILD.gn [delete] https://crrev.com/ec208f68dc1d5912215ee60bdc10d1e222862e2f/ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.h [delete] https://crrev.com/ec208f68dc1d5912215ee60bdc10d1e222862e2f/ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.mm [add] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/toolbar_button_factory.h [add] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/toolbar_button_factory.mm [add] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/toolbar_configuration.h [add] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/toolbar_configuration.mm [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/toolbar_constants.h [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/toolbar_constants.mm [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm [add] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/toolbar_style.h [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/showcase/toolbar/BUILD.gn [modify] https://crrev.com/cfbdcf9f687f82f584b48a3fa961b090c5ec3270/ios/showcase/toolbar/sc_toolbar_coordinator.mm
Comment 1 by bugdroid1@chromium.org
, Sep 11 2017