New issue
Advanced search Search tips

Issue 762568 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue 762894

Blocking:
issue 741235



Sign in to add a comment

sort out depot_tools' dependencies on the system

Project Member Reported by phajdan.jr@chromium.org, Sep 6 2017

Issue description

Tracking bug for improving/controlling depot_tools' dependencies on the system

Since depot_tools is one of the core dependencies, any work on install-build-deps.sh (see linked bug) depends on depot_tools "behaving" itself, i.e. having limited dependencies on the host system.

One of the ways I've been testing this is a vanilla debian stable chroot created using debootstrap.
 
Components: -Infra Infra>SDK
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/bfa05c838cf5e31bbc56e390d07d2da701f09ca4

commit bfa05c838cf5e31bbc56e390d07d2da701f09ca4
Author: Pawel Hajdan, Jr <phajdan.jr@chromium.org>
Date: Thu Sep 07 08:52:12 2017

update_depot_tools: make cipd_bin_setup failures fatal

This should make them more noticeable.

Bug: 762568
Change-Id: Ibd4ca4dc34d36aec5773d28454d134c909cc78dc
Reviewed-on: https://chromium-review.googlesource.com/653157
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/bfa05c838cf5e31bbc56e390d07d2da701f09ca4/update_depot_tools

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/8c8a0a56d41a37f67427a08b9c2c2fff587b3ba5

commit 8c8a0a56d41a37f67427a08b9c2c2fff587b3ba5
Author: Pawel Hajdan, Jr <phajdan.jr@chromium.org>
Date: Thu Sep 07 09:15:52 2017

cipd: also support wget as fetch command

On Debian's default install curl is not available, but wget is.

Bug: 762568
Change-Id: Ibc8c52676fd5e37ef1b9f1ffc061b2be27ec80c4
Reviewed-on: https://chromium-review.googlesource.com/653517
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/8c8a0a56d41a37f67427a08b9c2c2fff587b3ba5/cipd

Blockedon: 762894
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/2892e17932837133e2d968c956b75963df9fcc1b

commit 2892e17932837133e2d968c956b75963df9fcc1b
Author: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Date: Thu Sep 07 11:26:05 2017

Revert "update_depot_tools: make cipd_bin_setup failures fatal"

This reverts commit bfa05c838cf5e31bbc56e390d07d2da701f09ca4.

Reason for revert: breaks bot bootstrap

Original change's description:
> update_depot_tools: make cipd_bin_setup failures fatal
> 
> This should make them more noticeable.
> 
> Bug: 762568
> Change-Id: Ibd4ca4dc34d36aec5773d28454d134c909cc78dc
> Reviewed-on: https://chromium-review.googlesource.com/653157
> Reviewed-by: Daniel Jacques <dnj@chromium.org>
> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

TBR=phajdan.jr@chromium.org,dnj@chromium.org

Change-Id: I14e8aae77beca52ebbd21567e2ea20954e2b34d8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762894, 762568
Reviewed-on: https://chromium-review.googlesource.com/654977
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/2892e17932837133e2d968c956b75963df9fcc1b/update_depot_tools

Owner: ----
Status: Untriaged (was: Started)
Removing myself from bugs because of team transfer, back to re-triage.

See https://goto.google.com/phajdan-goodbye-chrome (Google-internal) and  issue 783662  .

In case of any questions, feel free to ask - use phajdan@google.com for a faster response.

Sign in to add a comment