New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762562 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

QuicStreamFactory::Job::Cancel() is unused

Project Member Reported by xunji...@chromium.org, Sep 6 2017 
While investigating Issue 750271, I noticed that QuicStreamFactory::Job::Cancel() is an unused method.

Filing a bug to investigate or get rid of that method if it's not needed.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6959e579e9a5baf79ca77fd9024aa4efa59098f9

commit 6959e579e9a5baf79ca77fd9024aa4efa59098f9
Author: Helen Li <xunjieli@chromium.org>
Date: Wed Sep 06 17:20:44 2017

Remove unused QuicStreamFactory::Job::Cancel()

The method is added in crrev.com/881133004 for racing two
QuicStreamFactory::Jobs. This logic has since been removed in
crrev.com/2820573004.

This CL removes the unused method.

Bug:  762562 ,  707953 
Change-Id: I2393713d816364e1002e75829cb6ade3873ad68d
Reviewed-on: https://chromium-review.googlesource.com/652959
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499996}
[modify] https://crrev.com/6959e579e9a5baf79ca77fd9024aa4efa59098f9/net/quic/chromium/quic_stream_factory.cc

Comment 2 by xunji...@chromium.org, Sep 6 2017

Labels: M-63
Owner: xunji...@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment