Issue metadata
Sign in to add a comment
|
42.8% regression in webrtc_perf_tests at 19663:19666 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 6 2017
,
Sep 6 2017
Could this be related to your change? https://chromium.googlesource.com/external/webrtc/+log/a0a5b98937de0f0bf90e17011d2cbc8c632cb409..f33cee7534f0469330b6b7aa57f84eec4b082598
,
Sep 7 2017
Added some more Ulpfec alerts to the report.
,
Sep 7 2017
I've done some testing and concluded that these regressions are not caused by the nack change linked. Instead, I can repro them locally by rolling past commit d4fac6957e14068f8dbf2ab4a20006b1df044274 Author: philipel <philipel@webrtc.org> Date: Mon Sep 4 07:03:46 2017 -0700 Unwrap picture ids in the RtpFrameReferencerFinder. Is the even a negative btw? Isn't being able to achieve a more stable high media and fec bitrate a good thing? In any case, philipel@ ptal
,
Sep 7 2017
Possible that it's not negative, but I'd like to understand why. :)
,
Sep 7 2017
Maybe it makes sense then that we only see Ulpfec alerts, but no Flexfec alerts: Ulpfec packets share the sequence number space with the media packets, but Flexfec does not.
,
Sep 7 2017
Yes, that sounds like a reasonable explanation. Sounds like we might have a bug here.
,
Oct 12 2017
Any progress on this one?
,
Dec 14 2017
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/1610f94ee35f788de9317a7c434448930eb121ed commit 1610f94ee35f788de9317a7c434448930eb121ed Author: philipel <philipel@webrtc.org> Date: Thu Dec 14 14:22:13 2017 Don't cast picture ids (of type int64_t) to int. Also cleaned up a bit in RtpFrameReferenceFinder. Bug: chromium:762556 Change-Id: Ib08d2e7ce4b146b359ce9ba823f3aa15776c71bc Reviewed-on: https://webrtc-review.googlesource.com/32301 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21282} [modify] https://crrev.com/1610f94ee35f788de9317a7c434448930eb121ed/modules/video_coding/frame_buffer2.cc [modify] https://crrev.com/1610f94ee35f788de9317a7c434448930eb121ed/modules/video_coding/frame_buffer2.h [modify] https://crrev.com/1610f94ee35f788de9317a7c434448930eb121ed/modules/video_coding/rtp_frame_reference_finder.cc [modify] https://crrev.com/1610f94ee35f788de9317a7c434448930eb121ed/modules/video_coding/rtp_frame_reference_finder.h [modify] https://crrev.com/1610f94ee35f788de9317a7c434448930eb121ed/video/video_receive_stream.cc
,
Dec 18 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 6 2017