New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762551 link

Starred by 1 user
Status: Fixed
Owner:
lizeb@chromium.org
Closed: Oct 2017
Cc:
█ wnwen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

MinAPI issue in TraceEvent.java:

Project Member Reported by wnwen@chromium.org, Sep 6 2017 
/tmp/tmpJEZvYT/SRC_ROOT1/base/android/java/src/org/chromium/base/TraceEvent.java:31 Class requires API level 19 (current min is 16): java.lang.AutoCloseable: NewApi [warning]
public class TraceEvent implements AutoCloseable {
                                   ~~~~~~~~~~~~~

This error was previously suppressed, but now is surfaced due to lint being updated and warnings unsuppressed in  issue 739746 

CL: https://chromium-review.googlesource.com/c/chromium/src/+/618717

Comment 1 by wnwen@chromium.org, Sep 6 2017 

Might not be a problem since it was just unhid in API level 19, but in any case we should either suppress the warning explicitly or fix it another way: https://b.corp.google.com/issues/36999599

Comment 3 by wnwen@chromium.org, Sep 6 2017

Cc: lizeb@chromium.org
Owner: wnwen@chromium.org
Status: Started (was: Assigned)
Will suppress in my CL to turn on lint.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41228577f586871e139fe554d532e4938cca9d6e

commit 41228577f586871e139fe554d532e4938cca9d6e
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Sep 11 14:57:49 2017

Android: Re-enable lint NewApi check

Now that platform-tools is rolled to version 26, we no longer need to
ignore lint failures due to platform differences. Prevents hard to debug
failures down the line due to API level mismatch.

Added suppressions and filed bugs for errors that crept in during the
time this was disabled. Effort should be put in next upgrade to not
allow this time to elapse.

BUG= 739746 , 762551 

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I28b1fa0e17a361bef8bfb522fb3ed59147b05d32
Reviewed-on: https://chromium-review.googlesource.com/652964
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500917}
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/android_webview/java/src/org/chromium/android_webview/AwAutofillManager.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/android_webview/java/src/org/chromium/android_webview/variations/AwVariationsConfigurationService.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/build/android/lint/suppressions.xml
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/res/drawable/ic_photo_camera_grey.xml
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/res/drawable/new_tab_icon.xml
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/DeviceConditions.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PictureInPictureControllerTest.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/ChannelsInitializerTest.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/ChannelsUpdaterTest.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/SiteChannelsManagerTest.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActionsNotificationTest.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/content/public/android/java/res/menu/select_action_menu.xml
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/content/public/android/java/src/org/chromium/content/browser/SmartSelectionProvider.java
[modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java

Comment 5 by wnwen@chromium.org, Sep 11 2017

Cc: -lizeb@chromium.org wnwen@chromium.org
Owner: lizeb@chromium.org
Status: Assigned (was: Started)
@Benoit - Please confirm that this is correct and sufficient for TraceEvent.java.

Comment 6 by lizeb@chromium.org, Oct 2 2017 

Yes, sorry for the delayed response, and thanks for looking into it!

Comment 7 by wnwen@chromium.org, Oct 2 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment