New issue
Advanced search Search tips

Issue 762550 link

Starred by 1 user
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

MinAPI issue in JavaHandlerThread.java and SystemMessageHandler.java

Project Member Reported by wnwen@chromium.org, Sep 6 2017 
/tmp/tmpJEZvYT/SRC_ROOT1/base/android/java/src/org/chromium/base/JavaHandlerThread.java:59 Call requires API level 23 (current min is 16): android.os.Looper#getQueue: NewApi [warning]
        MessageQueue queue = mThread.getLooper().getQueue();
                                                 ~~~~~~~~
/tmp/tmpJEZvYT/SRC_ROOT1/base/android/java/src/org/chromium/base/SystemMessageHandler.java:44 Call requires API level 23 (current min is 16): android.os.Looper#getQueue: NewApi [warning]
        Looper.myLooper().getQueue().addIdleHandler(mIdleHandler);
                          ~~~~~~~~
/tmp/tmpJEZvYT/SRC_ROOT1/base/android/java/src/org/chromium/base/SystemMessageHandler.java:77 Call requires API level 23 (current min is 16): android.os.Looper#getQueue: NewApi [warning]
        Looper.myLooper().getQueue().removeIdleHandler(mIdleHandler);

These errors were previously suppressed, but now are surfaced due to lint being updated and warnings unsuppressed in  issue 739746
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7d29c97cf19b8a671d72919468e75860f1c72c6

commit a7d29c97cf19b8a671d72919468e75860f1c72c6
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Wed Sep 06 16:14:12 2017

Fix NewApi warnings for Looper.myLooper().getQueue()

Uses an equivalent call available from API level 1.

Bug:  762550 
Change-Id: I06bb2dc42f7126cbe235cf4745fd35b29300abfa
Reviewed-on: https://chromium-review.googlesource.com/652594
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499981}
[modify] https://crrev.com/a7d29c97cf19b8a671d72919468e75860f1c72c6/base/android/java/src/org/chromium/base/JavaHandlerThread.java
[modify] https://crrev.com/a7d29c97cf19b8a671d72919468e75860f1c72c6/base/android/java/src/org/chromium/base/SystemMessageHandler.java

Comment 3 by mthiesse@chromium.org, Sep 6 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment