Issue metadata
Sign in to add a comment
|
PlzNavigate: inspector/network/network-datareceived.html number of byte received mismatch |
||||||||||||||||||||||||
Issue descriptionWith PlzNavigate(--enable-browser-side-navigation), the layout test: http/tests/inspector/network/network-datareceived.html fails. There is a mismatch between encodedBytesReceived(=323) and encodedDataLength(=50323). I am investigating...
,
Sep 7 2017
,
Sep 7 2017
Yes, you need to send the message. But I don't understand what you mean by "we probably need the async_resource_handler to send OnTransferSizeUpdated messages". Are you using mojo on content::AsyncResourceHandler?
,
Sep 7 2017
Yes you are right. I was not aware that LoadingWithMojo was enabled by default. Thanks!
So I have a much simpler explanation for this bug:
In MojoAsyncResourceHandler::OnReadCompleted():
```
const ResourceRequestInfoImpl* info = GetRequestInfo();
if (info->ShouldReportRawHeaders()) {
auto transfer_size_diff = CalculateRecentlyReceivedBytes();
if (transfer_size_diff > 0)
url_loader_client_->OnTransferSizeUpdated(transfer_size_diff);
}
```
OnTransferSizeUpdated is sent only if ShouldReportRawHeaders is enabled. It is enabled in InspectorNetworkAgent::WillSendRequest(). The latter is not called before the request is sent with PlzNavigate.
It means this bug is a duplicate of issue 760924 .
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by arthurso...@chromium.org
, Sep 7 2017