Content_Unittests-Viz: render_widget_host_view_guest_unittest |
||||
Issue descriptionrender_widget_host_view_guest_unittest.cc has dependencies on: - components/viz/common/surfaces/surface_sequence.h - components/viz/service/surfaces/surface.h - components/viz/service/surfaces/surface_manager.h - viz::mojom::CompositorFrameSinkPtr - viz::SurfaceId - viz::BeginFrameAck This affects the following test classes: - RenderWidgetHostViewGuestSurfaceTest - RenderWidgetHostViewGuestTest Find out how the Viz process split impacts this test, and update.
,
May 16 2018
Test fails cuz it doesn't like viz being on. % rr ctut --enable-features=VizDisplayCompositor --gtest_filter=*RenderWidgetHostViewGuestSurfaceTest* ninja: Entering directory `out_desktop/Release' ninja: no work to do. IMPORTANT DEBUGGING NOTE: batches of tests are run inside their own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with --single-process-tests. Using sharding settings from environment. This is shard 0/1 Using 1 parallel jobs. Note: Google Test filter = RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from RenderWidgetHostViewGuestSurfaceTest [ RUN ] RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface [158612:158612:0516/140748.851221:1391669144848:FATAL:render_widget_host_view_child_frame.cc(636)] Check failed: !enable_viz_. #0 0x7fb5ab642a2c base::debug::StackTrace::StackTrace() #1 0x7fb5ab583a2b logging::LogMessage::~LogMessage() #2 0x7fb5a990661a content::RenderWidgetHostViewChildFrame::SubmitCompositorFrame() #3 0x000000ad511f content::RenderWidgetHostViewGuestSurfaceTest_TestGuestSurface_Test::TestBody() #4 0x000001975aa2 testing::Test::Run() #5 0x000001976570 testing::TestInfo::Run() #6 0x000001976a77 testing::TestCase::Run() #7 0x000001982487 testing::internal::UnitTestImpl::RunAllTests() #8 0x00000198200d testing::UnitTest::Run() #9 0x000001aa9ea1 base::TestSuite::Run() #10 0x000001ab1df0 base::(anonymous namespace)::LaunchUnitTestsInternal() #11 0x000001ab1c40 base::LaunchUnitTests() #12 0x000001871266 main #13 0x7fb5a17652b1 __libc_start_main #14 0x00000067202a _start
,
May 16 2018
RenderWidgetHostViewGuestTest passes though
,
May 16 2018
RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface should not run when viz is on. Fady can you confirm please.
,
May 16 2018
The test reads that it is just testing the SubmitCompositorFrame() method that shouldn't be used with viz.
,
May 23 2018
I'll disable this and note it for future deletion in issue 844469
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e4de90373264dbe139cbba4ddea164416646cb1 commit 8e4de90373264dbe139cbba4ddea164416646cb1 Author: jonross <jonross@chromium.org> Date: Thu May 24 17:56:39 2018 Disable RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface on Viz RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface is obsolete once Viz has been enabled by default. This disables it in that state, with a note for me to delete it later. TEST=RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface Bug: 762521 Change-Id: I647b1abe0d88d3b65aef5965dddada1d95b5de42 Reviewed-on: https://chromium-review.googlesource.com/1070215 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561547} [modify] https://crrev.com/8e4de90373264dbe139cbba4ddea164416646cb1/content/browser/frame_host/render_widget_host_view_guest_unittest.cc [modify] https://crrev.com/8e4de90373264dbe139cbba4ddea164416646cb1/testing/buildbot/filters/viz.content_unittests.filter
,
May 25 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by laforge@google.com
, Nov 8 2017