In today's view widgets tiles of suggested sites are displaying in black |
|||||||||
Issue descriptionApp Version: 63.0.3207.0 Canary iOS Version: 9.3.5, 10.3.3, 11.0 beta 9 Device: iPhone and iPad Prerequisite: Add Canary- Suggested sites Widget to Today's View Steps to reproduce: 1. Launch chrome 2. Load CNN.com and wait until the webpage is loaded 3. Open a new tab page and tap on the device home button 4. Go to Today's view 5. Tap on show more or less button in the widget Observed results: Notice that all the tiles of the suggested sites are displaying black Expected results: The tiles should be displayed in black Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA (New feature of M62) Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M62 Link to video/image: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8QjJhMkFVd2JLczQ/view?usp=sharing
,
Sep 7 2017
lod@ please what's the status on this blocker? We aim to fix our blockers as early in the cycle as possible.
,
Sep 8 2017
I'm not managing to reliably repro this issue to fix it. I will probably not have a chance to fix it before going ooo tonight.
,
Sep 11 2017
Please find a new owner for this issue since Elodie is out for about 2 weeks.
,
Sep 12 2017
olivierrobin?
,
Sep 12 2017
A DCHECK is hit at 0 content_widget_extension 0x000000010013e3dc base::debug::BreakDebugger() + 320476 (debugger_posix.cc:258) 1 content_widget_extension 0x00000001001938c0 logging::LogMessage::~LogMessage() + 669888 (logging.cc:793) 2 content_widget_extension 0x00000001001908b4 logging::LogMessage::~LogMessage() + 657588 (logging.cc:794) 3 content_widget_extension 0x00000001000fa984 -[FaviconAttributes initWithImage:monogram:textColor:backgroundColor:defaultBackgroundColor:] + 43396 (favicon_attributes.mm:27) 4 content_widget_extension 0x00000001000fae84 +[FaviconAttributes attributesWithMonogram:textColor:backgroundColor:defaultBackgroundColor:] + 44676 (favicon_attributes.mm:53) 5 content_widget_extension 0x00000001000f655c -[ContentWidgetView updateSites:] + 25948 (content_widget_view.mm:188) 6 content_widget_extension 0x00000001000f8b30 -[ContentWidgetViewController updateWidget] + 35632 (content_widget_view_controller.mm:166) 7 content_widget_extension 0x00000001000f8270 -[ContentWidgetViewController widgetPerformUpdateWithCompletionHandler:] + 33392 (content_widget_view_controller.mm:107) 8 NotificationCenter 0x0000000199fe61d8 -[_NCWidgetViewController _performUpdateWithCompletionHandler:] + 180 9 CoreFoundation 0x0000000185594160 __invoking___ + 144 10 CoreFoundation 0x0000000185487c3c -[NSInvocation invoke] + 284
,
Sep 12 2017
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c6dd427eb22d3496cce2d6624df5413b42b8698 commit 8c6dd427eb22d3496cce2d6624df5413b42b8698 Author: Olivier Robin <olivierrobin@chromium.org> Date: Thu Sep 14 12:13:32 2017 Fix DCHECK when displaying empty icon in content extension. When saving an icon in background, the sandbox may already be locked. This result in saving failure and an empty icon being used in extension. This CL 1. Avoid to save empty icon 2. If the widget meets an empty icon at some point, tries to show a default icon instead of a black one. Bug: 762517 Change-Id: I66c248f00524900e2c240acb94bc1ed4b5654d5f Reviewed-on: https://chromium-review.googlesource.com/663261 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#501928} [modify] https://crrev.com/8c6dd427eb22d3496cce2d6624df5413b42b8698/ios/chrome/browser/ui/ntp/ntp_tile_saver.mm [modify] https://crrev.com/8c6dd427eb22d3496cce2d6624df5413b42b8698/ios/chrome/content_widget_extension/content_widget_view.mm
,
Sep 14 2017
,
Sep 14 2017
This bug requires manual review: Less than 29 days to go before AppStore submit on M62 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 19 2017
Merge approved upon verification for the fix in Canary
,
Sep 19 2017
Verified on 63.0.3219.0 Canary on iOS 11.0 iPad Pro 12'5 in, iPhone 7+ iOS 10.3.3. Looks good.
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dea6b155813f4822ed46ad9f5ce7d554e6378e16 commit dea6b155813f4822ed46ad9f5ce7d554e6378e16 Author: Olivier Robin <olivierrobin@chromium.org> Date: Thu Sep 21 13:54:10 2017 Fix DCHECK when displaying empty icon in content extension. When saving an icon in background, the sandbox may already be locked. This result in saving failure and an empty icon being used in extension. This CL 1. Avoid to save empty icon 2. If the widget meets an empty icon at some point, tries to show a default icon instead of a black one. Bug: 762517 Change-Id: I66c248f00524900e2c240acb94bc1ed4b5654d5f Reviewed-on: https://chromium-review.googlesource.com/663261 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501928}(cherry picked from commit 8c6dd427eb22d3496cce2d6624df5413b42b8698) Reviewed-on: https://chromium-review.googlesource.com/677363 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#375} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/dea6b155813f4822ed46ad9f5ce7d554e6378e16/ios/chrome/browser/ui/ntp/ntp_tile_saver.mm [modify] https://crrev.com/dea6b155813f4822ed46ad9f5ce7d554e6378e16/ios/chrome/content_widget_extension/content_widget_view.mm
,
Sep 27 2017
Devices: iPhone 6 plus, iPhone 7 plus, iPad Air iOS: 10.3.3, 11.0 Build: 62.0.3202.35 beta Verified following the steps mentioned in comment #0, the tiles are displayed in black. Looks good. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sczs@chromium.org
, Sep 6 2017Owner: lod@chromium.org
Status: Assigned (was: Untriaged)