New issue
Advanced search Search tips

Issue 762512 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 601869

Blocking:
issue 760320



Sign in to add a comment

Content_Unittests-Viz: ReflectorImplTest

Project Member Reported by jonr...@chromium.org, Sep 6 2017

Issue description

ReflectorImplTest has dependencies on:
  -  components/viz/common/frame_sinks/begin_frame_source.h
  -  components/viz/common/frame_sinks/delay_based_time_source.h
  -  components/viz/service/display_embedder/compositor_overlay_candidate_validator.h

Find out how the Viz process split impacts this test, and update.
 
We need to determine how Reflector will work in viz.

Comment 2 by laforge@google.com, Nov 8 2017

Components: -Internals>Viz Internals>Services>Viz
Migrating from Internals>Viz to Internals>Services>Viz.
Blockedon: 601869
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0c4e26bb5fe004283ad47673565f4f82b880fa9

commit b0c4e26bb5fe004283ad47673565f4f82b880fa9
Author: jonross <jonross@chromium.org>
Date: Tue Jul 31 13:05:54 2018

Update ReflectorImplTest to exit early for Viz

So Reflector doesn't work with VizDisplayCompositor yet at all. See
https://crbug.com/601869 for tracking getting this working again.

This updates the ReflectorImplTest to exit early when VizDisplayCompositor is
enabled. This is so that we can remove the filter files used for
content_unittests with Viz.

This change then also removes the filter file, and updates the bots.

TEST=ReflectorImplTest

Bug:  762512 
Change-Id: I5fa02925cbe3d961fbfa46f646b68b25da5671ed
Reviewed-on: https://chromium-review.googlesource.com/1153300
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579383}
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/content/test/BUILD.gn
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/testing/buildbot/chromium.win.json
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/6fdac1ab1ce62cfdd1b9e4e8c61cb39f20a3959e/testing/buildbot/filters/viz.content_unittests.filter
[modify] https://crrev.com/b0c4e26bb5fe004283ad47673565f4f82b880fa9/testing/buildbot/test_suites.pyl

Status: Fixed (was: Untriaged)
Tests early exit on Viz, issue 601869 tracks the re-write of Reflector

Sign in to add a comment